paragon icon indicating copy to clipboard operation
paragon copied to clipboard

feat: introduce as prop for Hyperlink

Open adamstankiewicz opened this issue 1 year ago • 2 comments

Description

Introduces as prop and types for Hyperlink to make it compatible with React Router's Link.

Note: May need to be updated after #3080 is reviewed/merged.

Deploy Preview

https://deploy-preview-3082--paragon-openedx.netlify.app/components/hyperlink

Merge Checklist

  • [ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • [ ] Does your change adhere to the documented style conventions?
  • [ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • [ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • [ ] Were your changes tested in the example app?
  • [ ] Is there adequate test coverage for your changes?
  • [ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • [ ] Verify your changes were released to NPM at the expected version.
  • [ ] If you'd like, share your contribution in #show-and-tell.
  • [ ] 🎉 🙌 Celebrate! Thanks for your contribution.

adamstankiewicz avatar May 29 '24 15:05 adamstankiewicz

Deploy Preview for paragon-openedx ready!

Name Link
Latest commit 9ead6aa1a48a479526929dcf2e2f1606522f892d
Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6657573524ba7f00088e2b55
Deploy Preview https://deploy-preview-3082--paragon-openedx.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 29 '24 15:05 netlify[bot]

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.40%. Comparing base (c5c48aa) to head (03705d5). Report is 3 commits behind head on release-22.x.

Files with missing lines Patch % Lines
src/Hyperlink/index.tsx 78.94% 4 Missing :warning:
Additional details and impacted files
@@               Coverage Diff                @@
##           release-22.x    #3082      +/-   ##
================================================
- Coverage         93.44%   93.40%   -0.05%     
================================================
  Files               251      251              
  Lines              4519     4531      +12     
  Branches           1055     1064       +9     
================================================
+ Hits               4223     4232       +9     
- Misses              293      296       +3     
  Partials              3        3              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 29 '24 15:05 codecov[bot]

Deploy Preview for paragon-openedx-v22 ready!

Name Link
Latest commit 03705d5900fdbd7e1efcc3dbdda1b914c6f8e075
Latest deploy log https://app.netlify.com/sites/paragon-openedx-v22/deploys/679a75455b83d90008862a1b
Deploy Preview https://deploy-preview-3082--paragon-openedx-v22.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jan 29 '25 16:01 netlify[bot]

:tada: This PR is included in version 22.15.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 23.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: