paragon icon indicating copy to clipboard operation
paragon copied to clipboard

feat: add LMS icons

Open brian-smith-tcril opened this issue 1 year ago • 2 comments

Description

Resolves https://github.com/openedx/paragon/issues/3024

image

Deploy Preview

https://deploy-preview-3029--paragon-openedx.netlify.app/foundations/lms-icons/

Merge Checklist

  • [ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • [ ] Does your change adhere to the documented style conventions?
  • [ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • [ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • [ ] Were your changes tested in the example app?
  • [ ] Is there adequate test coverage for your changes?
  • [ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • [ ] Verify your changes were released to NPM at the expected version.
  • [ ] If you'd like, share your contribution in #show-and-tell.
  • [ ] 🎉 🙌 Celebrate! Thanks for your contribution.

brian-smith-tcril avatar Apr 03 '24 14:04 brian-smith-tcril

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
Latest commit 2f68e54113d0e7e5947286b5dd961a8497b07911
Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6629650c83856f0009a4ae5d
Deploy Preview https://deploy-preview-3029--paragon-openedx.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 03 '24 14:04 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.18%. Comparing base (d67a04f) to head (48e51cf). Report is 1 commits behind head on master.

:exclamation: Current head 48e51cf differs from pull request most recent head 2f68e54. Consider uploading reports for the commit 2f68e54 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3029   +/-   ##
=======================================
  Coverage   93.18%   93.18%           
=======================================
  Files         249      249           
  Lines        4342     4342           
  Branches     1036     1036           
=======================================
  Hits         4046     4046           
  Misses        292      292           
  Partials        4        4           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 05 '24 17:04 codecov[bot]

@brian-smith-tcril If we don't need any additional reviewers, it looks like ready for merge.

ihor-romaniuk avatar Apr 15 '24 09:04 ihor-romaniuk

Based on the conversation from today's working group meeting https://openedx.atlassian.net/wiki/spaces/BPL/pages/4179132431/2024-04-17+Meeting+notes I will update the icons to not have hardcoded white for the checkmarks in the "complete" icons

brian-smith-tcril avatar Apr 17 '24 17:04 brian-smith-tcril

After a bit of investigation I found the circle with the checkmark is simply covering up the rest of the icon, and relies quite heavily on the fill and stroke. I'm not very experienced with advanced clip masking in svg, if someone else is more experienced and willing to take a stab at it that would be wonderful, if not I can do a deep dive into it tomorrow.

brian-smith-tcril avatar Apr 22 '24 14:04 brian-smith-tcril

:tada: This PR is included in version 22.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: