paragon icon indicating copy to clipboard operation
paragon copied to clipboard

[BD-46] feat: add new toast

Open khudym opened this issue 1 year ago • 3 comments

Description

Implemented new toast based on event emitter Issue#1858

Deploy Preview

components/toast

Merge Checklist

  • [ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • [ ] Does your change adhere to the documented style conventions?
  • [ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • [ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • [ ] Were your changes tested in the example app?
  • [ ] Is there adequate test coverage for your changes?
  • [ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • [ ] Verify your changes were released to NPM at the expected version.
  • [ ] If you'd like, share your contribution in #show-and-tell.
  • [ ] 🎉 🙌 Celebrate! Thanks for your contribution.

khudym avatar Dec 21 '23 14:12 khudym

Thanks for the pull request, @khudym!

When this pull request is ready, tag your edX technical lead.

openedx-webhooks avatar Dec 21 '23 14:12 openedx-webhooks

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
Latest commit 21168db4d5d11f7d433907f92652445c6230d475
Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6595448fbd76f100080b954c
Deploy Preview https://deploy-preview-2959--paragon-openedx.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Dec 21 '23 14:12 netlify[bot]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6927788) 93.00% compared to head (21168db) 93.05%.

Files Patch % Lines
src/Toast/BaseToast.jsx 90.90% 2 Missing :warning:
src/Toast/index.jsx 96.77% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2959      +/-   ##
==========================================
+ Coverage   93.00%   93.05%   +0.05%     
==========================================
  Files         236      239       +3     
  Lines        4273     4306      +33     
  Branches     1033     1036       +3     
==========================================
+ Hits         3974     4007      +33     
  Misses        295      295              
  Partials        4        4              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 03 '24 11:01 codecov[bot]