paragon icon indicating copy to clipboard operation
paragon copied to clipboard

[alpha] Refactoring the generate-component script

Open PKulkoRaccoonGang opened this issue 1 year ago • 3 comments

After switching to design tokens, in the Paragon repository (alpha branch), we stopped using the _variables.scss file in Paragon components. Given these changes, we must update the internal generate-component script in order to correctly generate the template for new components. This script still creates the _variables.scss.

image

We also need to update the documentation about the component generator on the corresponding page of the Paragon website

image image

### Tasks
- [ ] Ensure that the `_variables.scss` file is not created or imported after executing the generate-component script
- [ ] Ensure that the documentation (on the Paragon website) for the generate-component script is correct

PKulkoRaccoonGang avatar Nov 23 '23 14:11 PKulkoRaccoonGang

Since we are not adding many components, will we need a "component generator"? I would consider deprecating the component generator altogether and removing it from the code base. 🤔

monteri avatar Nov 28 '23 09:11 monteri

@adamstankiewicz Verify whether the Segment event with this CLI command is used by consumers.

adamstankiewicz avatar Dec 08 '23 14:12 adamstankiewicz

Let's not delete this script, it might be usefull in the future and it does not hurt anybody if it stays in the repository.

@PKulkoRaccoonGang please make these fixes, it will take you at most 10 minutes to do this 🙂

viktorrusakov avatar Dec 21 '23 10:12 viktorrusakov

Resolved in: https://github.com/openedx/paragon/pull/3076

PKulkoRaccoonGang avatar Jul 02 '24 10:07 PKulkoRaccoonGang