paragon
paragon copied to clipboard
feat: add twitter X icon to list of approved Bootstrap brandIconNames
Description
This PR adds the new Twitter "X" icon which is the updated branding.
Edit (@brian-smith-tcril):
- Rebased on latest
- Updated
bootstrap-icons
package to1.11.3
in the icons dirpackage.json
- Updated
copy-brand-icons
to look in./node_modules
(the icons directory node modules) instead of../
- Ran build in icons dir (it seems
1.11.3
made some minor changes to the icons. this is why this PR now has 198 files changed)
https://deploy-preview-2686--paragon-openedx.netlify.app/foundations/brand-icons/
bootstrap-icons
changes from 1.10.5
to 1.11.3
Before (1.10.5
)
After (1.11.3
)
Merge Checklist
- [x] Does your change adhere to the documented style conventions?
- [x] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
- [x] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
- [ ] Were your changes tested in the
example
app? - [ ] Is there adequate test coverage for your changes?
- [ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add
wittjeff
andadamstankiewicz
as reviewers on this PR.
Post-merge Checklist
Deploy Preview for paragon-openedx ready!
Name | Link |
---|---|
Latest commit | 044fc921fdcbee8bda7cb77a9e7245d515da5f88 |
Latest deploy log | https://app.netlify.com/sites/paragon-openedx/deploys/6632cfcf1dfc0900085e1b24 |
Deploy Preview | https://deploy-preview-2686--paragon-openedx.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.18%. Comparing base (
73f3ec6
) to head (044fc92
).
Additional details and impacted files
@@ Coverage Diff @@
## master #2686 +/- ##
=======================================
Coverage 93.18% 93.18%
=======================================
Files 249 249
Lines 4342 4342
Branches 1000 1034 +34
=======================================
Hits 4046 4046
Misses 293 293
Partials 3 3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:tada: This PR is included in version 22.4.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket: