paragon icon indicating copy to clipboard operation
paragon copied to clipboard

[BD-46] feat: added translations English strings in FormAutosuggest component

Open PKulkoRaccoonGang opened this issue 2 years ago β€’ 3 comments

Description

Paragon supports i18n, we should ensure all default English strings in the Form autosuggest component are marked for translation with react-intl.

Deploy Preview

FormAutosuggest component

Merge Checklist

  • [x] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • [x] Does your change adhere to the documented style conventions?
  • [x] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • [x] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • [x] Were your changes tested in the example app?
  • [x] Is there adequate test coverage for your changes?
  • [x] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • [ ] Verify your changes were released to NPM at the expected version.
  • [ ] If you'd like, share your contribution in #show-and-tell.
  • [ ] πŸŽ‰ πŸ™Œ Celebrate! Thanks for your contribution.

PKulkoRaccoonGang avatar Oct 24 '22 14:10 PKulkoRaccoonGang

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

openedx-webhooks avatar Oct 24 '22 14:10 openedx-webhooks

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
Latest commit d54568a7e9527a5772eaf3cbfd2339bf402cf27c
Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6357976500d9150009130eee
Deploy Preview https://deploy-preview-1711--paragon-openedx.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 24 '22 14:10 netlify[bot]

Codecov Report

Base: 90.51% // Head: 90.53% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (d54568a) compared to base (2abd5bc). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1711      +/-   ##
==========================================
+ Coverage   90.51%   90.53%   +0.01%     
==========================================
  Files         211      212       +1     
  Lines        3713     3717       +4     
  Branches      872      874       +2     
==========================================
+ Hits         3361     3365       +4     
  Misses        337      337              
  Partials       15       15              
Impacted Files Coverage Ξ”
src/Form/FormAutosuggest.jsx 93.47% <100.00%> (+0.21%) :arrow_up:
src/Form/messages.js 100.00% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 24 '22 19:10 codecov[bot]

@PKulkoRaccoonGang πŸŽ‰ Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Nov 04 '22 11:11 openedx-webhooks

:tada: This PR is included in version 20.18.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

edx-semantic-release avatar Nov 10 '22 14:11 edx-semantic-release