paragon
paragon copied to clipboard
[BD-46] feat: update truncate v3
Description
- Implement recursive solution for nested inner tags
- add doc strings for functions
- improve code
- update tests
- update exaple
Deploy Preview
https://deploy-preview-1702--paragon-openedx.netlify.app/components/truncate/
Merge Checklist
- [ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
- [ ] Does your change adhere to the documented style conventions?
- [ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
- [ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
- [ ] Were your changes tested in the
example
app? - [ ] Is there adequate test coverage for your changes?
- [ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add
wittjeff
andadamstankiewicz
as reviewers on this PR.
Post-merge Checklist
- [ ] Verify your changes were released to NPM at the expected version.
- [ ] If you'd like, share your contribution in #show-and-tell.
- [ ] π π Celebrate! Thanks for your contribution.
Thanks for the pull request, @monteri!
When this pull request is ready, tag your edX technical lead.
Deploy Preview for paragon-openedx ready!
Built without sensitive environment variables
Name | Link |
---|---|
Latest commit | c5f41327017bb2eae74f3100d63ab5a11d3ce108 |
Latest deploy log | https://app.netlify.com/sites/paragon-openedx/deploys/6352a6f340953b000ac8d7f6 |
Deploy Preview | https://deploy-preview-1702--paragon-openedx.netlify.app/components/truncate |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Codecov Report
Base: 90.51% // Head: 90.56% // Increases project coverage by +0.04%
:tada:
Coverage data is based on head (
c5f4132
) compared to base (7fbf86d
). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #1702 +/- ##
==========================================
+ Coverage 90.51% 90.56% +0.04%
==========================================
Files 211 211
Lines 3713 3729 +16
Branches 872 879 +7
==========================================
+ Hits 3361 3377 +16
Misses 337 337
Partials 15 15
Impacted Files | Coverage Ξ | |
---|---|---|
src/Truncate/index.jsx | 100.00% <100.00%> (ΓΈ) |
|
src/Truncate/utils.js | 100.00% <100.00%> (ΓΈ) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@monteri π Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
:tada: This PR is included in version 20.21.5 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 21.0.0-alpha.12 :tada:
The release is available on:
Your semantic-release bot :package::rocket: