paragon icon indicating copy to clipboard operation
paragon copied to clipboard

[BD-46] feat: update truncate v3

Open monteri opened this issue 2 years ago β€’ 3 comments

Description

  • Implement recursive solution for nested inner tags
  • add doc strings for functions
  • improve code
  • update tests
  • update exaple

Deploy Preview

https://deploy-preview-1702--paragon-openedx.netlify.app/components/truncate/

Merge Checklist

  • [ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • [ ] Does your change adhere to the documented style conventions?
  • [ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • [ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • [ ] Were your changes tested in the example app?
  • [ ] Is there adequate test coverage for your changes?
  • [ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • [ ] Verify your changes were released to NPM at the expected version.
  • [ ] If you'd like, share your contribution in #show-and-tell.
  • [ ] πŸŽ‰ πŸ™Œ Celebrate! Thanks for your contribution.

monteri avatar Oct 21 '22 13:10 monteri

Thanks for the pull request, @monteri!

When this pull request is ready, tag your edX technical lead.

openedx-webhooks avatar Oct 21 '22 13:10 openedx-webhooks

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
Latest commit c5f41327017bb2eae74f3100d63ab5a11d3ce108
Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6352a6f340953b000ac8d7f6
Deploy Preview https://deploy-preview-1702--paragon-openedx.netlify.app/components/truncate
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 21 '22 13:10 netlify[bot]

Codecov Report

Base: 90.51% // Head: 90.56% // Increases project coverage by +0.04% :tada:

Coverage data is based on head (c5f4132) compared to base (7fbf86d). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1702      +/-   ##
==========================================
+ Coverage   90.51%   90.56%   +0.04%     
==========================================
  Files         211      211              
  Lines        3713     3729      +16     
  Branches      872      879       +7     
==========================================
+ Hits         3361     3377      +16     
  Misses        337      337              
  Partials       15       15              
Impacted Files Coverage Ξ”
src/Truncate/index.jsx 100.00% <100.00%> (ΓΈ)
src/Truncate/utils.js 100.00% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 21 '22 13:10 codecov[bot]

@monteri πŸŽ‰ Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Dec 16 '22 13:12 openedx-webhooks

:tada: This PR is included in version 20.21.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

edx-semantic-release avatar Dec 16 '22 14:12 edx-semantic-release

:tada: This PR is included in version 21.0.0-alpha.12 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

edx-semantic-release avatar Feb 17 '23 13:02 edx-semantic-release