paragon icon indicating copy to clipboard operation
paragon copied to clipboard

[WS-3120] feat: add multiselect functionality to InputSelect

Open srwang opened this issue 3 years ago • 1 comments

Description

This PR implements multiselect functionality on the InputSelect component, which is currently being used widely across Publisher.

It looks like InputSelect will be deprecated, so at some point Publisher will need to be updated to use the newer Paragon Form components, and multi-select functionality will have to be implemented there. However, I thought that might be a separate scope of work - this PR is just to get the multiselect functionality into Publisher in the short-term so that we can use it.

See https://2u-internal.atlassian.net/browse/WS-3120

Merge Checklist

  • [x] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • [x] Does your change adhere to the documented style conventions?
  • [x] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • [ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • [ ] Were your changes tested in the example app?
  • [ ] Is there adequate test coverage for your changes?
  • [ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • [ ] Verify your changes were released to NPM at the expected version.
  • [ ] If you'd like, share your contribution in #show-and-tell.
  • [ ] 🎉 🙌 Celebrate! Thanks for your contribution.

srwang avatar Aug 11 '22 13:08 srwang

Deploy Preview for paragon-openedx ready!

Name Link
Latest commit 2071a1e1a750609d27e3737e79f084cb59cbe68a
Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/62f5075f5db3d60008a42eb6
Deploy Preview https://deploy-preview-1539--paragon-openedx.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 11 '22 13:08 netlify[bot]

@srwang I'm inclined to close this stale PR for now given that there's other ongoing work related to multiselect, for example: https://github.com/openedx/paragon/issues/1527 and https://github.com/openedx/paragon/issues/1420. Feel free to re-open or let me know if you feel otherwise, though :) Thanks!

adamstankiewicz avatar Jan 27 '23 21:01 adamstankiewicz