paragon icon indicating copy to clipboard operation
paragon copied to clipboard

Published 20 hours ago • verified publisher icon openedx

`npm run lint` seems to be returning SCSS linting errors (but not failing CI?)

Open adamstankiewicz opened this issue 2 years ago • 1 comments

On master, I ran npm i and then npm run lint and it results in 3936 linting errors (sample in screenshot). But, interestingly, none of these errors fail CI?

image

AC

  • Verify linting errors fail CI before PR merge
  • Verify whether we need to fix/ignore the SCSS linting errors returned.

adamstankiewicz avatar Jul 29 '22 10:07 adamstankiewicz

Hmm, we couldn't reproduce this locally, also I don't see any warnings in CI jobs that do linting check. Are you sure you were on the latest master and didn't have any changes in .eslitrc?

viktorrusakov avatar Aug 05 '22 07:08 viktorrusakov

Closing this since the issue is not reproduced anywhere.

viktorrusakov avatar Oct 09 '22 08:10 viktorrusakov