paragon
paragon copied to clipboard
initial draft of actionIcon prop for Card component
Description
This is an initial draft of actionIcon
property on the <Card />
component. The commit tests are not passing because I have not finished setting up .prettierrc.
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
- [ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
- [ ] Does your change adhere to the documented style conventions?
- [ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
- [ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
- [ ] Were your changes tested in the
example
app? - [ ] Is there adequate test coverage for your changes?
- [ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add
wittjeff
andadamstankiewicz
as reviewers on this PR.
Post-merge Checklist
- [ ] Verify your changes were released to NPM at the expected version.
- [ ] If you'd like, share your contribution in #show-and-tell.
- [ ] π π Celebrate! Thanks for your contribution.
Thanks for the pull request, @TheEarlyNerd! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
- supporting documentation
- Open edX discussion forum threads
- timeline information ("this must be merged by XX date", and why that is)
- partner information ("this is a course on edx.org")
- any other information that can help Product understand the context for the PR
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.
:warning: We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.
Deploy Preview for paragon-openedx ready!
Name | Link |
---|---|
Latest commit | 304143bc52d199cfd0167a873df0c48f284cf145 |
Latest deploy log | https://app.netlify.com/sites/paragon-openedx/deploys/62f1c0085e3c110008785c54 |
Deploy Preview | https://deploy-preview-1479--paragon-openedx.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Ugh, our bot tagged this as an OSPR due to the ongoing issue with CLA list. Once you hear from me about the CLA, this will be ok to merge. Removing the OSPR tag for now.
Codecov Report
Merging #1479 (6685dac) into master (dfc009c) will decrease coverage by
0.12%
. The diff coverage is44.44%
.
:exclamation: Current head 6685dac differs from pull request most recent head 304143b. Consider uploading reports for the commit 304143b to get more accurate results
@@ Coverage Diff @@
## master #1479 +/- ##
==========================================
- Coverage 91.44% 91.32% -0.13%
==========================================
Files 205 206 +1
Lines 3483 3492 +9
Branches 816 818 +2
==========================================
+ Hits 3185 3189 +4
- Misses 283 288 +5
Partials 15 15
Impacted Files | Coverage Ξ | |
---|---|---|
src/Card/CardActionIcon.jsx | 37.50% <37.50%> (ΓΈ) |
|
src/Card/index.jsx | 100.00% <100.00%> (ΓΈ) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.