Upgrade eslint to v8.x

Open BilalQamar95 opened this issue 2 years ago • 3 comments

Description

Ticket 42: Upgrade eslint to v8.x

Description:

Upgraded eslint to v8.18 along with @edx/eslint-config
Resolved linting issues post upgrade.

Merge Checklist

[ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
[ ] Does your change adhere to the documented style conventions?
[ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
[ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
[ ] Were your changes tested in the example app?
[ ] Is there adequate test coverage for your changes?
[ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

[ ] Verify your changes were released to NPM at the expected version.
[ ] If you'd like, share your contribution in #show-and-tell.
[ ] 🎉 🙌 Celebrate! Thanks for your contribution.

Jun 24 '22 13:06 BilalQamar95

Deploy Preview for paragon-openedx ready!

Name	Link
Latest commit	7e93f18ea9dfbd993584c0da2c04572da8b23268
Latest deploy log	https://app.netlify.com/sites/paragon-openedx/deploys/6332bc01b333170008d90381
Deploy Preview	https://deploy-preview-1421--paragon-openedx.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Jun 24 '22 13:06 netlify[bot]

Codecov Report

Base: 91.62% // Head: 90.40% // Decreases project coverage by -1.21% :warning:

Coverage data is based on head (c223aa7) compared to base (adf708d). Patch coverage: 72.01% of modified lines in pull request are covered.

:exclamation: Current head c223aa7 differs from pull request most recent head 7e93f18. Consider uploading reports for the commit 7e93f18 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1421      +/-   ##
==========================================
- Coverage   91.62%   90.40%   -1.22%     
==========================================
  Files         208      208              
  Lines        3547     3534      -13     
  Branches      824      824              
==========================================
- Hits         3250     3195      -55     
- Misses        282      324      +42     
  Partials       15       15

Impacted Files	Coverage Δ
src/Alert/index.jsx	`87.50% <0.00%> (-9.87%)`	:arrow_down:
src/Button/index.jsx	`73.33% <0.00%> (-26.67%)`	:arrow_down:
src/Card/CardStatus.jsx	`100.00% <ø> (ø)`
src/Collapsible/CollapsibleAdvanced.jsx	`88.57% <ø> (ø)`
src/Collapsible/CollapsibleVisible.jsx	`100.00% <ø> (ø)`
src/Collapsible/index.jsx	`69.23% <ø> (ø)`
src/DataTable/CardView.jsx	`20.00% <0.00%> (-7.28%)`	:arrow_down:
src/DataTable/SidebarFilters.jsx	`16.66% <0.00%> (-8.34%)`	:arrow_down:
src/DataTable/TableFilters.jsx	`30.00% <0.00%> (-10.00%)`	:arrow_down:
src/Dropdown/deprecated/index.jsx	`94.84% <ø> (ø)`
... and 105 more