paragon icon indicating copy to clipboard operation
paragon copied to clipboard

docs: ADR to expose all SCSS variables that MFEs use as CSS variables [BB-6307]

Open xitij2000 opened this issue 2 years ago • 5 comments

Description

Adds an ADR for a plan to expose all Bootstrap variables used by Paragon and MFEs as CSS variables.

Deploy Preview

NA

Merge Checklist

  • [x] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • [ ] Does your change adhere to the documented style conventions?
  • [x] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • [x] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • [x] Were your changes tested in the example app?
  • [x] Is there adequate test coverage for your changes?
  • [x] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • [ ] Verify your changes were released to NPM at the expected version.
  • [ ] If you'd like, share your contribution in #show-and-tell.
  • [ ] 🎉 🙌 Celebrate! Thanks for your contribution.

xitij2000 avatar Jun 16 '22 12:06 xitij2000

Thanks for the pull request, @xitij2000! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks avatar Jun 16 '22 12:06 openedx-webhooks

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
Latest commit d711d2e4716d36f8e2abff41cb3b118b5a40b8d8
Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/634668c832627f0009181b9f
Deploy Preview https://deploy-preview-1388--paragon-openedx.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jun 16 '22 12:06 netlify[bot]

Codecov Report

Base: 90.97% // Head: 90.36% // Decreases project coverage by -0.61% :warning:

Coverage data is based on head (d711d2e) compared to base (45887c9). Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1388      +/-   ##
==========================================
- Coverage   90.97%   90.36%   -0.62%     
==========================================
  Files         195      209      +14     
  Lines        3170     3581     +411     
  Branches      715      838     +123     
==========================================
+ Hits         2884     3236     +352     
- Misses        273      330      +57     
- Partials       13       15       +2     
Impacted Files Coverage Δ
src/Tabs/Tab.jsx 50.00% <0.00%> (-50.00%) :arrow_down:
src/Nav/index.jsx 50.00% <0.00%> (-50.00%) :arrow_down:
src/Navbar/index.jsx 52.17% <0.00%> (-32.04%) :arrow_down:
src/Modal/ModalLayer.jsx 68.42% <0.00%> (-31.58%) :arrow_down:
src/Button/index.jsx 73.33% <0.00%> (-26.67%) :arrow_down:
src/Popover/index.jsx 75.00% <0.00%> (-25.00%) :arrow_down:
src/Overlay/index.jsx 81.81% <0.00%> (-18.19%) :arrow_down:
src/Modal/AlertModal.jsx 33.33% <0.00%> (-16.67%) :arrow_down:
src/Modal/StandardModal.jsx 50.00% <0.00%> (-16.67%) :arrow_down:
src/Modal/FullscreenModal.jsx 50.00% <0.00%> (-16.67%) :arrow_down:
... and 100 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 16 '22 12:06 codecov[bot]

@xitij2000 Thank you for the contribution!

natabene avatar Jun 22 '22 15:06 natabene

I've created a starting implementation draft PR for this: https://github.com/openedx/paragon/pull/1620

xitij2000 avatar Sep 12 '22 13:09 xitij2000

@xitij2000 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Dec 26 '22 07:12 openedx-webhooks