frontend-app-learning icon indicating copy to clipboard operation
frontend-app-learning copied to clipboard

fix: modal size for lti content

Open Faraz32123 opened this issue 4 months ago • 1 comments

Ticket: COSMO2-716

  • dialogClassName was working with Modal from paragon, but after paragon v23 upgrade. We replaced Modal with ModalDialog with which dialogClassName doesn't work.
    • So, replace dialogClassName with simple className to apply same styles to get the past behavior for the modal.

Please review paragon v22 Modal Props VS paragon ModalDialog Props API which used className instead of dialogClassName.

Faraz32123 avatar Sep 05 '25 16:09 Faraz32123

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 90.83%. Comparing base (9bf5d01) to head (e66951c). :warning: Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1787   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files         344      344           
  Lines        5792     5792           
  Branches     1331     1372   +41     
=======================================
  Hits         5261     5261           
+ Misses        514      512    -2     
- Partials       17       19    +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Sep 05 '25 16:09 codecov[bot]