frontend-app-learning icon indicating copy to clipboard operation
frontend-app-learning copied to clipboard

feat: display the certificate available date if configured in progres tab

Open dcoa opened this issue 6 months ago • 2 comments

This Pull request aims to enhance the user experience by displaying the certificate_available_date in the progress tab > Certificate Status information if this has been configured and the course has not been complete yet.

Changes

  • Add the new certificate status in the CELEBRATION_STATUSES array.
  • Update the default message validating the certificate_available_date and using it if it is set (otherwise use the end course date).

[!IMPORTANT] This PR depends on https://github.com/openedx/edx-platform/pull/36790

Testing instructions

  • Enable the certificates.auto_certificate_generation waffle switch
  • Create a course with certificate mode (e.g. honor)
  • Configure a certificate available date in Studio entering in Course > Settings > Schedule & details
  • Enroll a learner in the course
  • Visit the progress tab and check the date in certificate status is the same as the one that you set (for this you will need the backend changes specified above)

If certificate available date is set image

If certificate available date is not set image

dcoa avatar May 26 '25 05:05 dcoa

Thanks for the pull request, @dcoa!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

openedx-webhooks avatar May 26 '25 05:05 openedx-webhooks

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 90.41%. Comparing base (b6c29df) to head (556ceea). :warning: Report is 34 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1715   +/-   ##
=======================================
  Coverage   90.41%   90.41%           
=======================================
  Files         343      343           
  Lines        5779     5779           
  Branches     1387     1388    +1     
=======================================
  Hits         5225     5225           
- Misses        535      537    +2     
+ Partials       19       17    -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 26 '25 05:05 codecov[bot]

@dcoa Thank you for this contribution!

On the corresponding edx-platform PR (https://github.com/openedx/edx-platform/pull/36790) I saw your note about the changes fixing an existing issue reported by BTR (https://github.com/openedx/frontend-app-authoring/issues/2051). So even though the two PRs impact user-facing behavior, I'm assuming they won't need to go through product review.

If I misunderstood please let me know.

CC @mphilbrick211

itsjeyd avatar Jun 05 '25 08:06 itsjeyd

@itsjeyd this issue no need product review

dcoa avatar Jun 11 '25 22:06 dcoa

@dcoa Thanks for confirming!

itsjeyd avatar Jun 12 '25 08:06 itsjeyd

@mariajgrimaldi please let me know when you review and merge the edx-platform PR I can help you to merge this PR.

farhaanbukhsh avatar Jun 20 '25 15:06 farhaanbukhsh

@crathbun428 - just double checking. Can we confirm that this is what we want from a POV to solve this issue?

mariajgrimaldi avatar Jun 30 '25 10:06 mariajgrimaldi

@farhaanbukhsh the backend PR has been merged, could you please review this again?

dcoa avatar Jul 10 '25 20:07 dcoa

@farhaanbukhsh: friendly ping :)

mariajgrimaldi avatar Jul 18 '25 15:07 mariajgrimaldi