frontend-app-learning icon indicating copy to clipboard operation
frontend-app-learning copied to clipboard

feat(OEXCOM-80): disable completion item icons on flag

Open holaontiveros opened this issue 7 months ago • 2 comments

fixes #1692

Description

Currently when the ENABLE_COMPLETION_TRACKING_SWITCH waffle switch is disabled the frontend doesn't take it into account and still displays completion for anything that was already completed.

This PRs uses the same API fo the sidebar toggles that already exists where in this PR for edx-platform was added the current status of the switch and based on that it changes how the "completion status" it's shown, which it would be the default for nothing being touched at that point on the course

Screenshots

flag disabled image

flag enabled image

holaontiveros avatar May 23 '25 15:05 holaontiveros

Thanks for the pull request, @holaontiveros!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

openedx-webhooks avatar May 23 '25 15:05 openedx-webhooks

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.43%. Comparing base (67bb54a) to head (4206dbf). Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1714      +/-   ##
==========================================
+ Coverage   90.42%   90.43%   +0.01%     
==========================================
  Files         344      344              
  Lines        5785     5793       +8     
  Branches     1348     1394      +46     
==========================================
+ Hits         5231     5239       +8     
+ Misses        537      535       -2     
- Partials       17       19       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 23 '25 15:05 codecov[bot]

@holaontiveros, the code looks good, thanks!

Can you please include step-by-step testing instructions in the PR, though? Assume the reviewer has a standard Tutor dev environment with the demo course loaded and this PR checked out and running, but nothing more.

@arbrandes Done, thank you

holaontiveros avatar Jun 04 '25 15:06 holaontiveros