fix: corrects the navigation issue if the student does not pass the entrance exam

[imasdekar]

• adds checks while rendering the next button text for status of the entrance exam.

closes #1415

Signed-off by: Ishan Masdekar [email protected]

[openedx-webhooks]

Thanks for the pull request, @imasdekar!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend-app-learning. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

[imasdekar]

@mphilbrick211 Can you please get the checks run and get this reviewed?

[GlugovGrGlib]

@imasdekar I believe we need to wait another week until @bradenmacdonald and @farhaanbukhsh take on maintainer responsibilities for this repo, after this it can be reviewed and scheduled for merge

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.80%. Comparing base (b9d1198) to head (c98da6d). Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1429      +/-   ##
==========================================
+ Coverage   87.78%   87.80%   +0.01%     
==========================================
  Files         310      310              
  Lines        5320     5328       +8     
  Branches     1350     1355       +5     
==========================================
+ Hits         4670     4678       +8     
  Misses        633      633              
  Partials       17       17              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[itsjeyd]

Hi @imasdekar, thank you for this contribution!

[itsjeyd]

OSPR management note: This PR includes user-facing changes. However, it fixes an existing bug (#1415) so there should be no need to send it through product review.

CC @jmakowski1123

[imasdekar]

@bradenmacdonald before implementing this fix on the frontend I dis check the backend and found that the entrance data is sent to the frontend and the respective data has a field which states that the user has failed the entrance exam. Hence I decided to utilise the same and implement a fix on the frontend.

[imasdekar]

I will add a test case and update this PR.

[imasdekar]

@bradenmacdonald If req. is also that further course data not be sent from the backend at all if the entrance exam status is failed then what exactly should be the response in such a case? I can work on this backend fix as well.

[bradenmacdonald]

Great! Replied on #1415.

[imasdekar]

@bradenmacdonald I've added tests as required.

[bradenmacdonald]

Thanks @imasdekar ! Unfortunately the test is not passing on CI - can you please take a quick look?

[imasdekar]

@bradenmacdonald apologies, it should work now. I missed to push a small update.