frontend-app-learning icon indicating copy to clipboard operation
frontend-app-learning copied to clipboard

fix: optimize scroll position observer after video fullscreen exit

Open ihor-romaniuk opened this issue 10 months ago • 3 comments

This merge request contains an optimization for toggling video xblock full-screen mode and saving the previous window top offset position on exit from the full-screen state.

With this refactor, we call scroll after exit full-screen mode only and not depends on xblock resize because sometimes the resize event comes before exiting full screen mode, and we don't need to call scroll every time on resize.

Related PR to quince branch: https://github.com/openedx/frontend-app-learning/pull/1370

ihor-romaniuk avatar Apr 25 '24 08:04 ihor-romaniuk