frontend-app-admin-portal
frontend-app-admin-portal copied to clipboard
fix: remove faker from application code
While testing the admin-portal, I noticed that the bundle size was huge and discovered that a lot of bloat is coming from the usage of faker.js in the application code. Faker.js should be limited to development and testing, as it has many definitions and seed data that can cause unnecessary bloat.
Here are some screenshots comparing the changes in bundle sizes before and after the change.
Before
Impact of Faker.js in the size
After
The Parsed bundle size fell from 5.84MB to 3.14MB as 46% reduction.
Caveat
I didn't particularly test the impact of this change on the functionality. I don't think there should be any. Mentioning it, just in case.
For all changes
- [ ] Ensure adequate tests are in place (or reviewed existing tests cover changes)
Only if submitting a visual change
- [ ] Ensure to attach screenshots
- [ ] Ensure to have UX team confirm screenshots
Thanks for the pull request, @tecoholic!
What's next?
Please work through the following steps to get your changes ready for engineering review:
:radio_button: Get product approval
If you haven't already, check this list to see if your contribution needs to go through the product review process.
- If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
- If it doesn't, simply proceed with the next step.
:radio_button: Provide context
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
- Dependencies
This PR must be merged before / after / at the same time as ...
- Blockers
This PR is waiting for OEP-1234 to be accepted.
- Timeline information
This PR must be merged by XX date because ...
- Partner information
This is for a course on edx.org.
- Supporting documentation
- Relevant Open edX discussion forum threads
:radio_button: Get a green build
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
:radio_button: Let us know that your PR is ready for review:
Who will review my changes?
This repository is currently unmaintained.
To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
- On the right-hand side of the PR, find the Contributions project, click the caret in the top right corner to expand it, and check the "Primary PM" field for the name of your PM.
- Find their GitHub handle here.
Where can I find more information?
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
- Overview of Review Process for Community Contributions
- Pull Request Status Guide
- Making changes to your pull request
When can I expect my changes to be merged?
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
- The size and impact of the changes that it introduces
- The need for product review
- Maintenance status of the parent repository
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.46%. Comparing base (
a19fe04
) to head (7c347e7
). Report is 87 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #1194 +/- ##
=======================================
Coverage 85.46% 85.46%
=======================================
Files 508 508
Lines 11074 11074
Branches 2329 2329
=======================================
Hits 9464 9464
Misses 1566 1566
Partials 44 44
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.