edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

Upgrade algoliasearch to v4

Open iamsobanjaved opened this issue 1 year ago • 7 comments

Recently algoliasearch released the new major version v4 of its Python client and it has multiple breaking changes, which will impact one of the edX platform plugins. So we must make that plugin compatible with algoliasearch v4 before upgrading this package.

Changelog: https://algolia.com/doc/libraries/python/v4/upgrade/

iamsobanjaved avatar Aug 21 '24 14:08 iamsobanjaved

This work should probably be moved to the website team. We can discuss when Jeremy returns, unless @spencertiberi wants to take care of ensuring this work gets ticketed by the other team. Additionally, we should point this ticket to any new tickets where applicable.

robrap avatar Aug 21 '24 16:08 robrap

Yes, this issue is created for the constraint to be compatible with this work (https://github.com/openedx/edx-platform/issues/35055). This dependency was added for the learner_recommendations app which then was transformed into a private edX platform plugin (https://github.com/openedx/edx-platform/pull/33782), which Aperture now owns. So this will go to Aperture and we can remove this dependency from here and add in that private plugin.

iamsobanjaved avatar Aug 21 '24 18:08 iamsobanjaved

Sounds good. Just making sure this makes it to an Aperture ticket then.

robrap avatar Aug 21 '24 18:08 robrap

@hurtstotouchfire - are you able to move this to Aperture's queue? Thanks!

jristau1984 avatar Aug 26 '24 13:08 jristau1984

@hurtstotouchfire one more ping.

jristau1984 avatar Sep 09 '24 14:09 jristau1984

FYI, I got a new github but haven't gotten around to fully transitioning access. Sorry about that. I'll probably be terrible about responding to pings on the new account as well though. 😅

@justinhynes can you get this into our backlog?

kbuchanan-2u avatar Sep 09 '24 14:09 kbuchanan-2u

All set, internal ticket is APER-3668.

justinhynes avatar Sep 10 '24 11:09 justinhynes

PR to address this issue: https://github.com/openedx/edx-platform/pull/36403

MaxFrank13 avatar Mar 18 '25 14:03 MaxFrank13