edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

Remove MongoDBProxy and Migrate to Native PyMongo Retry Functionality

Open yashathwani opened this issue 1 year ago • 4 comments

Description

This pull request removes the custom MongoDBProxy package from the edx-platform and updates the codebase to use PyMongo's built-in retryable reads and writes features. This change is intended to simplify the codebase by eliminating the need for the custom package and leveraging the native support provided by recent versions of PyMongo.

Impact on User Roles:

Developer: Developers will no longer need to maintain the MongoDBProxy package and will use PyMongo's built-in features for retries. Operator: Operators will benefit from a more streamlined and supported connection handling process.

Resolves #35210

yashathwani avatar Aug 01 '24 08:08 yashathwani

Thanks for the pull request, @yashathwani!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

:radio_button: Submit a signed contributor agreement (CLA)

:warning: We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation. Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment below that you have signed it. If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

openedx-webhooks avatar Aug 01 '24 08:08 openedx-webhooks

@yashathwani this is a really valuable PR, I hope you're still interested in getting it merged. Let me know if there is any way I can help with the CLA or with getting CI to pass.

kdmccormick avatar Aug 20 '24 18:08 kdmccormick

@yashathwani , do you plan on finishing this PR?

kdmccormick avatar Sep 05 '24 12:09 kdmccormick

@mphilbrick211 do you know what state this contributor's CLA is in?

kdmccormick avatar Sep 05 '24 12:09 kdmccormick

Hi @yashathwani , since we have not heard from you, I have opened a new iteration of this PR: https://github.com/openedx/edx-platform/pull/35556

kdmccormick avatar Sep 27 '24 18:09 kdmccormick