edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

Backport to Quince: survey report changes

Open luisfelipec95 opened this issue 1 year ago • 5 comments

Description

This is a backport to Quince.

  • https://github.com/openedx/edx-platform/pull/33633 (This PR adds a custom banner message to the admin site. Right now the message only appears if a survey report hasn't been generated in 6 months but this threshold is configurable . Also this PR will send the report when it's generated as well.)
  • https://github.com/openedx/edx-platform/pull/33623 (This PR only adds extra information to the Survey Report Django App in the README.)
  • https://github.com/openedx/edx-platform/pull/33954 (This PR adds the code that allows editing the value of the setting ANONYMOUS_SURVEY_REPORT from ENV_TOKENS.)
  • https://github.com/openedx/edx-platform/pull/34033 (This PR introduces a refactor of the Survey Report management in the Django admin site. The changes include two key modifications aimed at enhancing the clarity and functionality of the admin interface.)
  • https://github.com/openedx/edx-platform/pull/34092 (This PR adds a new setting ENABLE_SURVEY_REPORT which determines if the Survey Report Banner should appear or disable it entirely in the django admin.)
  • https://github.com/openedx/edx-platform/pull/34126 (This PR introduces a refactor of the Survey Report management in the Django admin site.)
  • https://github.com/openedx/edx-platform/pull/34127 (Adding a New State "Sent" to Reports)
  • https://github.com/openedx/edx-platform/pull/34160 (This PR introduces a dismiss button to hide the survey report banner and a thank-you message to users upon report submission.)

luisfelipec95 avatar Jan 12 '24 03:01 luisfelipec95

Thanks for the pull request, @luisfelipec95!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

openedx-webhooks avatar Jan 12 '24 03:01 openedx-webhooks

@luisfelipec95, the #34033 was merged; you can cherry-pick it.

MaferMazu avatar Jan 16 '24 21:01 MaferMazu

I'll be reviewing this as part of the BTR anytime soon. Thanks!

mariajgrimaldi avatar Jan 22 '24 13:01 mariajgrimaldi

Hi there! Please let me know when this is ready for review. Thanks!

mariajgrimaldi avatar Feb 05 '24 14:02 mariajgrimaldi

Hi there! Please let me know when this is ready for review. Thanks!

This is already for review @mariajgrimaldi

Alec4r avatar Mar 06 '24 13:03 Alec4r

We usually try not to backport features in case is absolutely necessary. @Alec4r @luisfelipec95, is this still needed since it was already included in Redwood? if not, can we close this PR? Thanks!

mariajgrimaldi avatar Jul 22 '24 15:07 mariajgrimaldi

We usually try not to backport features in case is absolutely necessary. @Alec4r @luisfelipec95, is this still needed since it was already included in Redwood? if not, can we close this PR? Thanks!

Friendly ping on this @Alec4r @luisfelipec95!

mphilbrick211 avatar Aug 23 '24 20:08 mphilbrick211

@mariajgrimaldi @mphilbrick211 Thank you for following up on this! Since the changes have already been included in Redwood, we no longer need this backport. You can go ahead and close the PR.

Thanks again for your support!

Alec4r avatar Aug 24 '24 00:08 Alec4r

@luisfelipec95 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Aug 26 '24 15:08 openedx-webhooks