edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

Survey xblock not working properly inside the Mobile apps' webview

Open miankhalid opened this issue 1 year ago • 14 comments

Hi folks 👋

Here to report an issue with the Survey xBlock's display inside our Mobile apps, plz have a look at the screenshots below:

Example 1 Example 2

After some client-side CSS injection magic:

Example 1 Example 2

cc @forgotvas @moiz994 @touchapp @hassan6190

miankhalid avatar Jan 05 '24 17:01 miankhalid

@openedx/edx-infinity team would you folks be able to help here?

miankhalid avatar Jan 05 '24 17:01 miankhalid

This issue has been resolved in this PR.

eemaanamir avatar Feb 12 '24 10:02 eemaanamir

@openedx/edx-infinity team would you folks be able to help here?

@miankhalid The issue has been resolved

ayesha-waris avatar Feb 12 '24 10:02 ayesha-waris

thanks @ayesha-waris, lemme ask my team to verify the fix on our end as well.

miankhalid avatar Feb 12 '24 10:02 miankhalid

@eemaanamir @ayesha-waris sadly, the issue isn't fully fixed. Plz have a look at the issues still occurring after the fix:

New line bug incase of Radio buttons Alignment issue incase of percentages

miankhalid avatar Feb 12 '24 13:02 miankhalid

@eemaanamir @ayesha-waris sadly, the issue isn't fully fixed. Plz have a look at the issues still occurring after the fix:

New line bug incase of Radio buttons Alignment issue incase of percentages

@miankhalid Thanks for confirmation, will get back to you once its resolved properly

ayesha-waris avatar Feb 12 '24 14:02 ayesha-waris

@miankhalid The new line issue is not reproducible on our end. Please take a look at the following screenshots. Varying dimensions have been used to test the problem.

Screenshot 2024-02-12 at 9 40 07 PM Screenshot 2024-02-12 at 9 40 28 PM

Furthermore, the alignment bug is also not visible.

Screenshot 2024-02-12 at 9 41 33 PM

How are you producing the alignment bug in the first place? To my understanding, the total sum of all the percentages should not exceed 100%, but that is not the case in the screenshot you provided. Are you producing the bug using CSS manipulation? If yes, maybe that is the culprit behind the issue.

eemaanamir avatar Feb 12 '24 16:02 eemaanamir

How are you producing the alignment bug in the first place? To my understanding, the total sum of all the percentages should not exceed 100%, but that is not the case in the screenshot you provided. Are you producing the bug using CSS manipulation? If yes, maybe that is the culprit behind the issue.

@forgotvas thoughts on these questions?

miankhalid avatar Feb 13 '24 06:02 miankhalid

hi @eemaanamir, that bug i can still reproduce on that xblock. Possible i can reproduce that because on device we have width that less than 767px that limited in @media css: Снимок экрана 2024-02-13 в 10 56 24 | Снимок экрана 2024-02-13 в 10 54 23

Sum of percentages is not equal to 100 because it's a hard coded and i don't think that you have calculated css that depends on value there:

https://github.com/openedx/edx-platform/assets/480059/22240ecb-4eff-4eb8-95a1-e4621691c283

The new line issue still reproduced on my side, i went through html tags, possible that will help you to find a reason:

https://github.com/openedx/edx-platform/assets/480059/3ecb865a-1322-4330-8f7e-abcc37319e42

cc @miankhalid

forgotvas avatar Feb 13 '24 08:02 forgotvas

This issue has been addressed in this PR.

awais-ansari avatar Feb 27 '24 10:02 awais-ansari

hi @awais-ansari, i can confirm that bug with new line was fixed, percent vertical alignment looks good too, but there also exist new one bug with percentage:

New line(fixed) Percent vertical alignment (fixed) New percent bug with new line
new line vertical alignment new bug

cc @miankhalid

forgotvas avatar Feb 28 '24 12:02 forgotvas

hi @awais-ansari, do you have any updates for this bug? Simulator Screenshot - iPhone 15 Plus - 2024-03-21 at 12 07 13

cc @miankhalid

forgotvas avatar Mar 21 '24 11:03 forgotvas

@eemaanamir Can you please confirm that it is fixed or not?

awais-ansari avatar Mar 21 '24 11:03 awais-ansari

Here is a fix. https://github.com/openedx/edx-platform/pull/34408

awais-ansari avatar Mar 21 '24 17:03 awais-ansari