edx-platform
edx-platform copied to clipboard
openedx
feat: Added correct image for FB sharing (master)
Issue
This pull request addresses the issue related to missing Open Graph (OG) image metadata in the HTML.
Context
The absence of the <meta property="og:image" /> tag was causing issues with social media sharing and previewing content. This addition ensures that the correct OG image is associated with the page for improved sharing capabilities.
Related Pull Requests
- master - https://github.com/openedx/edx-platform/pull/33784
- quince.master - https://github.com/openedx/edx-platform/pull/33785
- redwood.master - https://github.com/openedx/edx-platform/pull/34919
Thanks for the pull request, @vladislavkeblysh!
What's next?
Please work through the following steps to get your changes ready for engineering review:
:radio_button: Get product approval
If you haven't already, check this list to see if your contribution needs to go through the product review process.
- If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
- If it doesn't, simply proceed with the next step.
:radio_button: Provide context
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
- Dependencies
This PR must be merged before / after / at the same time as ...
- Blockers
This PR is waiting for OEP-1234 to be accepted.
- Timeline information
This PR must be merged by XX date because ...
- Partner information
This is for a course on edx.org.
- Supporting documentation
- Relevant Open edX discussion forum threads
:radio_button: Get a green build
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
:radio_button: Let us know that your PR is ready for review:
Who will review my changes?
This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.
Where can I find more information?
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
- Overview of Review Process for Community Contributions
- Pull Request Status Guide
- Making changes to your pull request
When can I expect my changes to be merged?
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
- The size and impact of the changes that it introduces
- The need for product review
- Maintenance status of the parent repository
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
Hi @vladislavkeblysh! Just checking in to see if you plan to pursue this pull request?
Hi there, @vladislavkeblysh! Thanks for the fix. Could you add testing instructions to the PR cover letter so it's easier for reviewers?
Hi there, @vladislavkeblysh! Thanks for the fix. Could you add testing instructions to the PR cover letter so it's easier for reviewers?
Hi @mariajgrimaldi Sorry for the delayed response, I found this PR just 15 minutes ago 😔
This fix was developed a long time ago and I might miss some details, but here is how I believe it could be tested:
On the course about page click on the "share" button:
Check the result with/without the fix:
before (the favicon is used for the image or no image at all)
after (course image is presented)
Note: it could take some time for FB crawlers to update the sharing info
