edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

feat: remove the broken Zooming Image Tool

Open arbrandes opened this issue 2 years ago • 3 comments

Description

The Zooming Image Tool does not currently work, and the security implications of getting such external Javascript to function properly are unclear at best. We should simply remove it from the list of HTML block templates.

Supporting information

The failure was discovered as part of release testing for Olive undertaken by the Build-Test-Release working group.

Testing instructions

To test, simply note that the Zooming Image Tool is no longer given as an option when instantiating a new Text block in Studio.

Deadline

Palm

arbrandes avatar Dec 12 '22 13:12 arbrandes

@ormsbee, do you happen to have some context on this to give it a once-over? Any idea who I should tag on the 2U side?

arbrandes avatar Jan 30 '23 14:01 arbrandes

This probably deserves a DEPR, even if it's broken (so that we have the justification somewhere). @dianakhuang, @feanil: In the case where something has been broken for a really long time, is DEPR notice + immediate removal the right thing to do?

FYI @mondiaz

ormsbee avatar Jan 30 '23 15:01 ormsbee

@ormsbee Agreed, it would be good to have have a depr but you can mark it as immediately accepted in this case since we've accepted it being broken for such a long time.

feanil avatar Feb 05 '23 18:02 feanil