edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

Bszabo/tnl 10136 student course enrollment

Open bszabo opened this issue 2 years ago • 1 comments

This is an incremental step towards teasing apart a course enrollment model out of the existing student model in edx-platform. These changes are intended to be non-breaking. Please fail the PR if that objective goes unmet.

Model code had previously all resided in a single student/models.py module. Now it resides in two modules, one for student modeling and one for course enrollment modeling.

Database tables remain as is.

Importing of student and course enrollment models remain as is.

bszabo avatar Oct 28 '22 18:10 bszabo

Great use of atomic commits here it makes reading the story of this revision much easier.

connorhaugh avatar Nov 02 '22 13:11 connorhaugh

In side channel slack conversation, Alexander confirmed that none of these changes broke the edx-enterprise build, and that the extraction of the course enrollment from the student model looks largely correct (suitable first approximation).

bszabo avatar Nov 16 '22 20:11 bszabo

@bszabo If you could hi light any changes required by the merge, I would be happy to give this a second thumb upon review of those changes.

connorhaugh avatar Nov 28 '22 13:11 connorhaugh

Hi @bszabo should this PR be closed?

e0d avatar Nov 20 '23 21:11 e0d

Closing since there hasn't been a response in a while.

feanil avatar Apr 24 '24 16:04 feanil