edx-platform
edx-platform copied to clipboard
Feat: Persian language support added
Hello edx Since the beginning of my acquaintance with the edx platform, I always wondered, why t doesn't support Farsi. well, I'm glad to announce that we translated the Persian language (fa_IR) in Transifex. right now both translated and reviewed statuses are at 100%.
I wanted to add .po
and .mo
files to the PR but noticed that Jenkins CI is responsible for that.
is there anything else I need to add?
Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
- supporting documentation
- Open edX discussion forum threads
- timeline information ("this must be merged by XX date", and why that is)
- partner information ("this is a course on edx.org")
- any other information that can help Product understand the context for the PR
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Thanks for this contribution, @CodeWithEmad ! I don't know much about how the translation system works so I can't be your reviewer here, but I did have a question for you: Were you able to get this working locally, by manually updating the po/mo files? And if so, can you attach some screenshots?
Hi @bradenmacdonald. sorry for the late response.
Yes, I did actually. to add translations for a new language we only have to add .po
and .mo
files to the /openedx/locale/user/locale/
and build a new openedx image.
I'm using tutor to run openedx and in tutor, first we put translations in $(tutor config printroot)/env/build/openedx/locale
and tutor will copy them to /openedx/locale/user/locale/
.
adding a new DarkLangConfig (something like en,fa_ir
will add English and Persian(Farsi) Language to the openedx.
LMS:
CMS:
feel free to ask more on this matter.
I'll be more than happy to add .po
and .mo
files, if any CI apo is not responsible for that
@bradenmacdonald also, I've ceated a PR for adding Persian Translations to some of the MFEs (Account, Profile, Learning, and Gradebook) but so long, no one reached to review/add/fix the PR. by any chance, do you know anyone related to MFE repositories?
@CodeWithEmad Thanks. I asked a couple people about your MFE PRs.
I appreciate it man.
@Carlos-Muniz @ghassanmas would either of you be appropriate reviewers for this?
I am not sure about this change, probably @Carlos-Muniz would know better. It seems to be that the uncommented language in the conf/locale/config.yaml
would let the Jenkis/transifex bot to pull it from transifex.
The thing is I can't be sure because I don't know where the bot code is, on the other hand, Carlos work with openedx/open-edx-proposals/pull/367 might alter the de-facto process/workflow which uses conf/locale/config.yaml
.
@CodeWithEmad @Carlos-Muniz hi there! Just checking in on this to see if tests should be re-run to get the PR through?
@Carlos-Muniz just making sure this is ready to merge?
@mphilbrick211 Yes. It is ready to merge.
Hi @bmtcril - would you mind taking a look at this and merging?
@CodeWithEmad 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.
EdX Release Notice: This PR has been deployed to the production environment.
EdX Release Notice: This PR has been deployed to the production environment.