edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

Feat: Persian language support added

Open CodeWithEmad opened this issue 2 years ago • 8 comments

Hello edx Since the beginning of my acquaintance with the edx platform, I always wondered, why t doesn't support Farsi. well, I'm glad to announce that we translated the Persian language (fa_IR) in Transifex. right now both translated and reviewed statuses are at 100%.

I wanted to add .po and .mo files to the PR but noticed that Jenkins CI is responsible for that. is there anything else I need to add?

CodeWithEmad avatar Oct 13 '22 16:10 CodeWithEmad

Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks avatar Oct 13 '22 16:10 openedx-webhooks

Thanks for this contribution, @CodeWithEmad ! I don't know much about how the translation system works so I can't be your reviewer here, but I did have a question for you: Were you able to get this working locally, by manually updating the po/mo files? And if so, can you attach some screenshots?

bradenmacdonald avatar Oct 19 '22 18:10 bradenmacdonald

Hi @bradenmacdonald. sorry for the late response. Yes, I did actually. to add translations for a new language we only have to add .po and .mo files to the /openedx/locale/user/locale/ and build a new openedx image. I'm using tutor to run openedx and in tutor, first we put translations in $(tutor config printroot)/env/build/openedx/locale and tutor will copy them to /openedx/locale/user/locale/. adding a new DarkLangConfig (something like en,fa_ir will add English and Persian(Farsi) Language to the openedx. LMS: Screenshot from 2022-10-23 11-14-54 CMS: Screenshot from 2022-10-23 11-22-06 feel free to ask more on this matter.

CodeWithEmad avatar Oct 23 '22 07:10 CodeWithEmad

I'll be more than happy to add .po and .mo files, if any CI apo is not responsible for that

CodeWithEmad avatar Oct 23 '22 07:10 CodeWithEmad

@bradenmacdonald also, I've ceated a PR for adding Persian Translations to some of the MFEs (Account, Profile, Learning, and Gradebook) but so long, no one reached to review/add/fix the PR. by any chance, do you know anyone related to MFE repositories?

CodeWithEmad avatar Oct 23 '22 07:10 CodeWithEmad

@CodeWithEmad Thanks. I asked a couple people about your MFE PRs.

bradenmacdonald avatar Oct 24 '22 17:10 bradenmacdonald

I appreciate it man.

CodeWithEmad avatar Oct 25 '22 06:10 CodeWithEmad

@Carlos-Muniz @ghassanmas would either of you be appropriate reviewers for this?

e0d avatar Nov 04 '22 22:11 e0d

I am not sure about this change, probably @Carlos-Muniz would know better. It seems to be that the uncommented language in the conf/locale/config.yaml would let the Jenkis/transifex bot to pull it from transifex. The thing is I can't be sure because I don't know where the bot code is, on the other hand, Carlos work with openedx/open-edx-proposals/pull/367 might alter the de-facto process/workflow which uses conf/locale/config.yaml.

ghassanmas avatar Nov 06 '22 09:11 ghassanmas

@CodeWithEmad @Carlos-Muniz hi there! Just checking in on this to see if tests should be re-run to get the PR through?

mphilbrick211 avatar Dec 16 '22 17:12 mphilbrick211

@Carlos-Muniz just making sure this is ready to merge?

mphilbrick211 avatar Dec 27 '22 18:12 mphilbrick211

@mphilbrick211 Yes. It is ready to merge.

Carlos-Muniz avatar Jan 03 '23 14:01 Carlos-Muniz

Hi @bmtcril - would you mind taking a look at this and merging?

mphilbrick211 avatar Jan 13 '23 15:01 mphilbrick211

@CodeWithEmad 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Jan 18 '23 15:01 openedx-webhooks

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

edx-pipeline-bot avatar Jan 18 '23 16:01 edx-pipeline-bot

EdX Release Notice: This PR has been deployed to the production environment.

edx-pipeline-bot avatar Jan 18 '23 16:01 edx-pipeline-bot

EdX Release Notice: This PR has been deployed to the production environment.

edx-pipeline-bot avatar Jan 18 '23 16:01 edx-pipeline-bot