edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

Published 20 hours ago • verified publisher icon openedx

fix via styles discussion-alert when it's in MFE

Open bydawen opened this issue 2 years ago • 5 comments

Fix for the discussion-alert when it appears in the MFE, or when discussion is stopped.

bydawen avatar Sep 23 '22 09:09 bydawen

Thanks for the pull request, @bydawen! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks avatar Sep 23 '22 09:09 openedx-webhooks

Hi! I'm contributing on behalf of Raccoongang

bydawen avatar Sep 23 '22 09:09 bydawen

@e0d Do we know if RC have confirmed?

natabene avatar Sep 27 '22 17:09 natabene

Note: @bydawen has been confirmed, see #30998. I will un-freeze the CI checks now.

bradenmacdonald avatar Oct 21 '22 18:10 bradenmacdonald

📣 💥 Heads-up: You must either rebase onto master or merge master into your branch to keep passing required checks.

We added a new required check, "Tests Successful," that this PR does not yet run. Rebasing will get it started.

If you have any questions, please reach out to the Architecture team (either #architecture on Open edX Slack or #external-architecture on edX internal Slack).

nedbat avatar Oct 31 '22 19:10 nedbat

Hi @bydawen! Just following up on this. Are you planning to pursue this PR? If so, looks like you'll need to re-run some failing tests. Also, flagging Ned's comment above from Oct. 31.

mphilbrick211 avatar Dec 16 '22 16:12 mphilbrick211

Hi @bydawen friendly ping on this - please let us know if you plan to pursue this PR. Thanks!

mphilbrick211 avatar Dec 27 '22 19:12 mphilbrick211

Hi @bydawen! Friendly ping on this. Please let us know if you plan to pursue this PR. If not, we will close and it can be reopened in the future if needed.

mphilbrick211 avatar Jan 23 '23 21:01 mphilbrick211

Hi @bydawen! I'm going to close this pull request due to inactivity, but you may reopen it if needed if you plan to pursue. Thanks!

mphilbrick211 avatar Feb 07 '23 19:02 mphilbrick211

@bydawen Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Feb 07 '23 19:02 openedx-webhooks