edx-platform
edx-platform copied to clipboard
Fixed bootstrap layout for the program_details_view.underscore
Fix bootstrap classes for the program details template, to correct responsive behaviour
Thanks for the pull request, @bydawen! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
- supporting documentation
- Open edX discussion forum threads
- timeline information ("this must be merged by XX date", and why that is)
- partner information ("this is a course on edx.org")
- any other information that can help Product understand the context for the PR
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Hi! I'm contributing on behalf of Raccoongang
@bydawen Thank you for the contribution, we will be able to review once you agreement has been sorted out.
@e0d Has the Raccoon Gang sorted this out?
@natabene @e0d I've added Oleksander to the RG CLA-staff list. Hope this will help to pass openedx/cla checker.
@idegtiarov It may take a while. Try checking back tomorrow. The way to re-run the cla check is to edit title and save.
@idegtiarov It's always good to ping us directly when you've updated the spreadsheet. I've added him to your org, the file will be pushed in a couple of hours.
@e0d Thank you very much!
I kicked off the tests.
@natabene fixed long commit message, please check from your side, thanks in advance
Do you have any before/after screenshots you can attach? I don't see anything particularly scary but it's useful to see what exactly what the change looks like, especially at different responsive breakpoints.
@rgraber yeah, sure, here screenshots what problem we got before, and screens after fixes. Decided to make content in one column to prevent content deformation in the responsive view
Is the strange indent/spacing on "Certificate Status" a pre-existing thing? I can't tell from the screenshots
Is the strange indent/spacing on "Certificate Status" a pre-existing thing? I can't tell from the screenshots
@rgraber all that we have changed, it's only bootstrap layout classes, all other things remain as it be before
Is the strange indent/spacing on "Certificate Status" a pre-existing thing? I can't tell from the screenshots
@rgraber all that we have changed, it's only bootstrap layout classes, all other things remain as it be before
My concern was that changing the bootstrap classes changed the formatting of something accidentally, but looking at it again it looks like "Certificate Status" was always indented, it just looked different because there didn't used to be buttons above it. That's fine, I'll approve.
@bydawen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.
EdX Release Notice: This PR has been deployed to the production environment.