edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

Fixed bootstrap layout for the program_details_view.underscore

Open bydawen opened this issue 2 years ago • 13 comments

Fix bootstrap classes for the program details template, to correct responsive behaviour

bydawen avatar Sep 15 '22 11:09 bydawen

Thanks for the pull request, @bydawen! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks avatar Sep 15 '22 11:09 openedx-webhooks

Hi! I'm contributing on behalf of Raccoongang

bydawen avatar Sep 15 '22 11:09 bydawen

@bydawen Thank you for the contribution, we will be able to review once you agreement has been sorted out.

natabene avatar Sep 19 '22 15:09 natabene

@e0d Has the Raccoon Gang sorted this out?

natabene avatar Sep 27 '22 16:09 natabene

@natabene @e0d I've added Oleksander to the RG CLA-staff list. Hope this will help to pass openedx/cla checker.

idegtiarov avatar Sep 29 '22 16:09 idegtiarov

@idegtiarov It may take a while. Try checking back tomorrow. The way to re-run the cla check is to edit title and save.

natabene avatar Sep 29 '22 16:09 natabene

@idegtiarov It's always good to ping us directly when you've updated the spreadsheet. I've added him to your org, the file will be pushed in a couple of hours.

e0d avatar Sep 29 '22 18:09 e0d

@e0d Thank you very much!

idegtiarov avatar Sep 29 '22 19:09 idegtiarov

I kicked off the tests.

natabene avatar Oct 13 '22 19:10 natabene

@natabene fixed long commit message, please check from your side, thanks in advance

bydawen avatar Oct 17 '22 14:10 bydawen

Do you have any before/after screenshots you can attach? I don't see anything particularly scary but it's useful to see what exactly what the change looks like, especially at different responsive breakpoints.

rgraber avatar Oct 19 '22 16:10 rgraber

@rgraber yeah, sure, here screenshots what problem we got before, and screens after fixes. Decided to make content in one column to prevent content deformation in the responsive view

image5 Снимок экрана 2022-10-20 в 10 47 47 Снимок экрана 2022-10-20 в 10 47 57

bydawen avatar Oct 20 '22 07:10 bydawen

Is the strange indent/spacing on "Certificate Status" a pre-existing thing? I can't tell from the screenshots

rgraber avatar Oct 21 '22 17:10 rgraber

Is the strange indent/spacing on "Certificate Status" a pre-existing thing? I can't tell from the screenshots

@rgraber all that we have changed, it's only bootstrap layout classes, all other things remain as it be before

bydawen avatar Nov 23 '22 09:11 bydawen

Is the strange indent/spacing on "Certificate Status" a pre-existing thing? I can't tell from the screenshots

@rgraber all that we have changed, it's only bootstrap layout classes, all other things remain as it be before

My concern was that changing the bootstrap classes changed the formatting of something accidentally, but looking at it again it looks like "Certificate Status" was always indented, it just looked different because there didn't used to be buttons above it. That's fine, I'll approve.

rgraber avatar Nov 29 '22 13:11 rgraber

@bydawen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Nov 29 '22 13:11 openedx-webhooks

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

edx-pipeline-bot avatar Nov 29 '22 15:11 edx-pipeline-bot

EdX Release Notice: This PR has been deployed to the production environment.

edx-pipeline-bot avatar Nov 29 '22 16:11 edx-pipeline-bot