edx-platform
edx-platform copied to clipboard
openedx
feat: added organization dropdown in studio
Description
This PR adds a dropdown to select the organization. The dropdown will only be activated for users with CourseCreator permission to specific organizations in Studio.
Use cases:
When FEATURES['ENABLE_CREATOR_GROUP'] = True and the user has CourseCreator permission granted, a dropdown will appear with all specific organizations allowed. In case of all_organizations setting is enabled, all organizations will appear in the dropdown.
In case the user is staff, he can create organizations it will work as before:
Testing instructions
- Enable course creator group in studio.
- Create a student account and give it CourseCreator permission only for some organizations.
- Login as this user and try to create a new course.
Result:
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
- supporting documentation
- Open edX discussion forum threads
- timeline information ("this must be merged by XX date", and why that is)
- partner information ("this is a course on edx.org")
- any other information that can help Product understand the context for the PR
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
@natabene I was waiting for feedback from the community. Do you know someone that maybe interested or has knowledge of the CourseCreator permission?
cc @MaferMazu @mariajgrimaldi
Hello @natabene! I can review this one. But I have a question: since it changes in some way the user experience, should we include a product review? Or this minimal change doesn't need it? It's unclear to me how this is handled.
Hi, Jon here from the UX team. I'm unable to test, but based on the screenshot this looks like a nice improvement.
Hi @jfay1, thanks for the reply
Would you mind explaining why you were unable to test it?
Are you facing some error?
Hi @Ian2012, no errors but I'm wondering if I need to test on a certain site? Sometimes I'm sent a test link on stage etc.
I'm not sure how to get to the screen in step 2 but I do have permission to create courses in studio. When I create a new course I see the old field, but that's what I would expect.
Hey @jmakowski1123 what do you think of this feature. I think that currently it is very annoying to have to know the name of the organization, there is a lot of room for error and this could be solved Do you think anything could be improved?
@Ian2012 I think this is a good improvement; you should try to fix the test to have a proper review.
Hey @jmakowski1123 what do you think of this feature. I think that currently it is very annoying to have to know the name of the organization, there is a lot of room for error and this could be solved Do you think anything could be improved?
@santiagosuarezedunext It seems to be a useful feature in terms of fixing a known pain point. What does the behavior look like if there are multiple organizations listed in the dropdown? Do they display alphabetically? Is a user able to scroll through the full list of enabled organizations, as well as start typing an organization and be offered a dropdown of selections based on what he/she typed?
Hi @jmakowski1123,
What does the behavior look like if there are multiple organizations listed in the dropdown?
The organizations will be sorted by id (creation date).
Is a user able to scroll through the full list of enabled organizations, as well as start typing an organization and be offered a dropdown of selections based on what he/she typed?
No, the dropdown was added because it worked like that before (with the option to type in) but users don't really know which organizations they have access.
Staff users and users with permission to create organizations still have the old input (type and get suggestions)
I've tested the following in my local environment:
- ENABLE_CREATOR_GROUP disabled
- Instructor with permission to all organizations
- Instructor with permission to just one organization
Technically, this is working like a charm—also, thanks @Ian2012, for considering my suggestions. Given this is under product review, I won't leave my approval yet.
@Ian2012: we need to wait for the product review.
Is there anything we could do in the meantime? @jmakowski1123
We backport these changes to our Nutmeg instance and It's working, we are expecting for this merge in master.
Flagging this for you @jmakowski1123 and @productryan - please let me know if you've had a chance to review. (Ryan, for some reason I cannot add you as a reviewer).
Hi, my name is Brad and I am the product manager for TNL (edx.org Studio). I think this is a good change and makes the product easier to use. It's a useful enhancement and I will move it along to engineering review.
Hi @jmakowski1123 and @ProductRyan - looks like this still needs product input.
Hi @jmakowski1123 and @ProductRyan - looks like this still needs product input.
Oops, sorry, realized @cablaa77 reviewed! Thanks!
Flagging this as I think it's ready for you to review/merge @mariajgrimaldi :)
@Ian2012 can you rebase with the master branch? so we can merge. Also @mphilbrick211, thanks for the ping! This PR still has the product review label, should we remove it?
@Ian2012 can you rebase with the master branch? so we can merge. Also @mphilbrick211, thanks for the ping! This PR still has the product review label, should we remove it?
@mariajgrimaldi - we're planning to leave those labels on just in case for some reason we need to go back to this PR (or any PR that was marked for Product review. Thank you for checking!
@mphilbrick211 good! -just checking- this can be merged, right -from the product view-?
@mphilbrick211 good! -just checking- this can be merged, right -from the product view-?
@mariajgrimaldi Looks like it per @cablaa77's comment above!
@mphilbrick211: the branch is still out-of-date, once @Ian2012 updates it, I'll merge this :)