edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

Published 20 hours ago • verified publisher icon openedx

make "GET STARTED" link look better

Open nikitakoselev opened this issue 2 years ago • 4 comments

It looks cleaner when you can just click on GET STARTED, instead of seeing the long link.

###Before image

###After image

nikitakoselev avatar Jun 15 '22 19:06 nikitakoselev

Thanks for the pull request, @nikitakoselev! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks avatar Jun 15 '22 19:06 openedx-webhooks

@nikitakoselev Thank you for the contribution. Someone will review this soon.

natabene avatar Jun 22 '22 14:06 natabene

Hello @natabene, there's an issue with the CLA

mariajgrimaldi avatar Sep 02 '22 19:09 mariajgrimaldi

Can you update the commit message to follow conventional commits (OEP-51)

I guess this would be a docs commit

pdpinch avatar Sep 03 '22 15:09 pdpinch

Hi @nikitakoselev! Are you planning to pursue this PR? If so, you will need to complete the CLA form and re-run some failing checks. Please let me know if you have any questions. Thank you!

mphilbrick211 avatar Dec 12 '22 21:12 mphilbrick211

Shanme on me. Got called away with community work. Let me try to fix it tomorrow, during the stream.

nikitakoselev avatar Dec 12 '22 23:12 nikitakoselev

Hi @nikitakoselev! Are you planning to pursue this PR? If so, you will need to complete the CLA form and re-run some failing checks. Please let me know if you have any questions. Thank you!

Hi @nikitakoselev - just following up on the items above :)

mphilbrick211 avatar Dec 27 '22 19:12 mphilbrick211

I have completed the CLA form. Thank you for reminding.

nikitakoselev avatar Dec 28 '22 06:12 nikitakoselev

Hi @nikitakoselev! Just following up on this. If you re-run the tests, your CLA check should go green. Looks like there are some other failing tests. Please let me know if you have any questions.

mphilbrick211 avatar Jan 23 '23 23:01 mphilbrick211

@nikitakoselev Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Jan 24 '23 06:01 openedx-webhooks

Issues stopping me from continuing on this ticket:

  • no write access
  • I cannot "rerun the tests"
  • I had to fill CLA twice

Result: I am closing the PR. Anyone with more time than me is welcome to re-open it and find a way to get the change done.

nikitakoselev avatar Jan 24 '23 06:01 nikitakoselev

Hey, sorry this was a frustrating experience for you. Thanks for your feedback.

e0d avatar Jan 30 '23 19:01 e0d