edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

[WIP] fix: fix npm cli by marking fsevents optional

Open ghassanmas opened this issue 3 years ago • 3 comments

Description

Attempt to fix npm ci by marking an instance of fsevents as optinal in package-lock.json

ghassanmas avatar May 25 '22 13:05 ghassanmas

Thanks for the pull request, @ghassanmas! I've created OSPR-6720 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

openedx-webhooks avatar May 25 '22 13:05 openedx-webhooks

@ghassanmas Thank you for the contribution, is this ready for our review?

natabene avatar May 26 '22 17:05 natabene

@natabene this was an attemp to fix something when nutmeg.master was usign node 16, but however since nutmeg.master is now using node 12 again. This change may not make much sense. I will mark it as WIP, so may be it would be useful/relavant in the future.

ghassanmas avatar Jun 01 '22 07:06 ghassanmas

Hi @ghassanmas can this be closed?

mphilbrick211 avatar Dec 27 '22 18:12 mphilbrick211

~~Yes this was for testing/experiments purpose.~~

Edit: oh no it wasn't for experiments purpose I was referring to other PR.

In any case this change is related to nutmeg which if we don't actually support then this should be closed.

In case we still need to support nutmeg, I will need to give another look/revisit before giving an opinion

ghassanmas avatar Dec 27 '22 19:12 ghassanmas

Hi @ghassanmas - just checking back on this - can this be closed?

mphilbrick211 avatar Apr 04 '23 01:04 mphilbrick211

@mphilbrick211 we can in favour #31887 which a candidate for fixing a the same problem (part of it)

ghassanmas avatar Apr 04 '23 01:04 ghassanmas

@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Apr 04 '23 01:04 openedx-webhooks