edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

Carrying over aed/analytics-exporter-settings-hotfix's work and disab…

Open estute opened this issue 5 years ago • 2 comments

…ling the course lookup if a list is provided

Please consider the following when opening a pull request:

  • Link to the relevant JIRA ticket(s) and tag any relevant team(s).
  • Squash your changes down into one or more discrete commits. In each commit, include description that could help a developer several months from now.
  • If running make upgrade, run as close to the time of merging as possible to avoid accidentally downgrading someone else's package. Put the output of make upgrade in its own separate commit, decoupled from other code changes.
  • Aim for comprehensive test coverage, but remember that automated testing isn't a substitute for manual verification.
  • Carefully consider naming, code organization, dependencies when adding new code. Code that is amenable to refactoring and improvement benefits all platform developers, especially given the size and scope of edx-platform. Consult existing Architectural Decision Records (ADRs), including those concerning the app(s) you are changing and those concerning edx-platform as a whole.

estute avatar Nov 22 '19 19:11 estute

Your PR has finished running tests. The following contexts failed:

  • codecov/project

edx-status-bot avatar Nov 22 '19 19:11 edx-status-bot

📣 💥 Heads-up: You must either rebase onto master or merge master into your branch to avoid breaking the build.

We recently removed diff-quality and introduced lint-amnesty. This means that the automated quality check that has run on your branch doesn't work the same way it will on master. If you have introduced any quality failures, they might pass on the PR but then break the build on master.

This branch has been detected to not have commit 2e335653 as an ancestor. Here's how to see for yourself:

git merge-base --is-ancestor 2e335653 estute/analytics-exporter-settings-hotfix && echo "You're all set" || echo "Please rebase onto master or merge master to your branch"

If you have any questions, please reach out to the Architecture team (either #edx-shared-architecture on Open edX Slack or #architecture on edX internal).

arch-bom-gocd-alerts avatar Jun 11 '21 18:06 arch-bom-gocd-alerts