edx-ora2 | Replace pkg_resources to importlib_resources | Drop support for python 3.8
Overview
This PR:
- replaces
pkg_resourcesapi fromimportlib_resourcesapi. (resolves #2225) - drops support for
python 3.8and add support forpython 3.11. (resolves #2230)
Tickets:
Screenshots
Hi @ttqureshi -- I'm working my way through the PR backlog for this repo, apologies for letting this one go stale! Could you resolve the conflicts so I can review & merge?
Hi @ttqureshi -- I'm working my way through the PR backlog for this repo, apologies for letting this one go stale! Could you resolve the conflicts so I can review & merge?
sure
conflicts resolved
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.29%. Comparing base (
42e754e) to head (8ea48d4). Report is 21 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #2238 +/- ##
==========================================
+ Coverage 95.23% 95.29% +0.05%
==========================================
Files 195 195
Lines 21606 21624 +18
Branches 1502 1502
==========================================
+ Hits 20576 20606 +30
+ Misses 784 771 -13
- Partials 246 247 +1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 95.29% <100.00%> (+0.05%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @ttqureshi -- I'm not sure why I have to keep allowing the CI to run here, but I bet it's frustrating to have to wait for me to know when you've fixed all the errors :(
You can run the tests locally using tox, e.g.
python3.11 -m venv venv311
source venv311/bin/activate
pip install tox
TOXENV=quality tox
TOXENV=django42 tox
If you want to run the 3.12 tests, use python 3.12 to create your virtualenv.
Thanks @pomegranited for the heads-up! I’ll run the tests locally with tox to catch any errors before pushing. Appreciate the tips.
@ttqureshi we're so close now!
So close @ttqureshi ! Just need a little more code coverage -- the easiest way to spot the missing lines is to look for the inline codecov warnings like these.
So close @ttqureshi ! Just need a little more code coverage -- the easiest way to spot the missing lines is to look for the inline codecov warnings like these.
alright 👍
@pomegranited I hope it's done now :)
@ttqureshi Tests are all green now! Thank you so much for persisting with this change. Merging now :)