edx-ora2 icon indicating copy to clipboard operation
edx-ora2 copied to clipboard

edx-ora2 | Replace pkg_resources to importlib_resources | Drop support for python 3.8

Open ttqureshi opened this issue 1 year ago • 4 comments

Overview

This PR:

  • replaces pkg_resources api from importlib_resources api. (resolves #2225)
  • drops support for python 3.8 and add support for python 3.11. (resolves #2230)

Tickets:

Screenshots

image image

ttqureshi avatar Sep 30 '24 07:09 ttqureshi

Hi @ttqureshi -- I'm working my way through the PR backlog for this repo, apologies for letting this one go stale! Could you resolve the conflicts so I can review & merge?

pomegranited avatar Oct 31 '24 00:10 pomegranited

Hi @ttqureshi -- I'm working my way through the PR backlog for this repo, apologies for letting this one go stale! Could you resolve the conflicts so I can review & merge?

sure

ttqureshi avatar Oct 31 '24 05:10 ttqureshi

conflicts resolved

ttqureshi avatar Oct 31 '24 05:10 ttqureshi

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.29%. Comparing base (42e754e) to head (8ea48d4). Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2238      +/-   ##
==========================================
+ Coverage   95.23%   95.29%   +0.05%     
==========================================
  Files         195      195              
  Lines       21606    21624      +18     
  Branches     1502     1502              
==========================================
+ Hits        20576    20606      +30     
+ Misses        784      771      -13     
- Partials      246      247       +1     
Flag Coverage Δ
unittests 95.29% <100.00%> (+0.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 31 '24 06:10 codecov[bot]

Hi @ttqureshi -- I'm not sure why I have to keep allowing the CI to run here, but I bet it's frustrating to have to wait for me to know when you've fixed all the errors :(

You can run the tests locally using tox, e.g.

python3.11 -m venv venv311
source venv311/bin/activate
pip install tox
TOXENV=quality tox
TOXENV=django42 tox

If you want to run the 3.12 tests, use python 3.12 to create your virtualenv.

pomegranited avatar Nov 06 '24 02:11 pomegranited

Thanks @pomegranited for the heads-up! I’ll run the tests locally with tox to catch any errors before pushing. Appreciate the tips.

ttqureshi avatar Nov 06 '24 04:11 ttqureshi

@ttqureshi we're so close now!

pomegranited avatar Nov 07 '24 03:11 pomegranited

So close @ttqureshi ! Just need a little more code coverage -- the easiest way to spot the missing lines is to look for the inline codecov warnings like these.

pomegranited avatar Nov 08 '24 02:11 pomegranited

So close @ttqureshi ! Just need a little more code coverage -- the easiest way to spot the missing lines is to look for the inline codecov warnings like these.

alright 👍

ttqureshi avatar Nov 08 '24 06:11 ttqureshi

@pomegranited I hope it's done now :)

ttqureshi avatar Nov 08 '24 07:11 ttqureshi

@ttqureshi Tests are all green now! Thank you so much for persisting with this change. Merging now :)

pomegranited avatar Nov 12 '24 01:11 pomegranited