edx-ora2
edx-ora2 copied to clipboard
chore: update help text of top responses setting and translations
TL;DR - Add a small change on help text of "Top Responses" setting to make it clearer to instructor. This is a re-done PR in place of #1870 as @ngdangdat couldn't get the CLA Signed.
JIRA: NA
What changed?
- Help text of the "Top Responses" setting
- Related translation files
Developer Checklist
- [x] Reviewed the release process
- [x] Translations and JS/SASS compiled
- [ ] Bumped version number in setup.py and package.json
Testing Instructions
- Checkout branch open-craft:update-help-text-of-top-reponses-setting
- Install
edx-ora2
xblock on the feature branch to Studio (CMS) - Restart CMS
- Add a ORA block in a unit
- Edit > Settings
- Make sure the changed text show up properly
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
- [ ] I've done a visual code review
- [ ] I've tested the new functionality
FYI: @openedx/content-aurora
Thanks for the pull request, @tecoholic! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
- supporting documentation
- Open edX discussion forum threads
- timeline information ("this must be merged by XX date", and why that is)
- partner information ("this is a course on edx.org")
- any other information that can help Product understand the context for the PR
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
@tecoholic Thank you for your contribution, I am kicking off the tests.
@natabene Thank you.
Note to the reviewer: The tests are failing due to CodeCov API call failing.
Hey @tecoholic, should we keep this PR open or can it be closed?
@itsjeyd I think it is still relevant. It is a copy of the @gabrieldamours' change here.
@gabrieldamours Can you kindly confirm?
This might require a rebase/recompiling on master. I can updated it once it is confirmed.
Sounds good @tecoholic, thanks for the update.
@tecoholic yep, this PR is still relevant 👍
@tecoholic @gabrieldamours OK great! I'll let you schedule the next steps for an upcoming OpenCraft sprint :)
@mphilbrick211 In the meantime, we should probably label this as waiting for author (or move it to the Blocked column on the contributions board)?
@itsjeyd Hi, I have re-based this on the master and updated the PR. Who should I ping to review this?
Codecov Report
Base: 94.98% // Head: 94.98% // No change to project coverage :thumbsup:
Coverage data is based on head (
7b951c6
) compared to base (5fa43f2
). Patch has no changes to coverable lines.
Additional details and impacted files
@@ Coverage Diff @@
## master #1883 +/- ##
=======================================
Coverage 94.98% 94.98%
=======================================
Files 153 153
Lines 17044 17044
Branches 1873 1873
=======================================
Hits 16189 16189
Misses 641 641
Partials 214 214
Flag | Coverage Δ | |
---|---|---|
unittests | 94.98% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
My apologies for not seeing this. It looks like this is ready to be reviewed and merged! Looks like @mattcarter can review as he is the contact for the repo.
@tecoholic @mphilbrick211 Thanks for the updates :+1:
@tecoholic 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.