openedx
build: enable CI for pull requests
This change enables CI checks for PRs targeted against branches other than master.
This is useful for stacked PRs, as it allows to run checks for all dependent PRs.
Thanks for the pull request, @0x29a!
What's next?
Please work through the following steps to get your changes ready for engineering review:
:radio_button: Get product approval
If you haven't already, check this list to see if your contribution needs to go through the product review process.
- If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
- If it doesn't, simply proceed with the next step.
:radio_button: Provide context
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
- Dependencies
This PR must be merged before / after / at the same time as ...
- Blockers
This PR is waiting for OEP-1234 to be accepted.
- Timeline information
This PR must be merged by XX date because ...
- Partner information
This is for a course on edx.org.
- Supporting documentation
- Relevant Open edX discussion forum threads
:radio_button: Get a green build
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
:radio_button: Let us know that your PR is ready for review:
Who will review my changes?
This repository is currently unmaintained.
To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
- On the right-hand side of the PR, find the Contributions project, click the caret in the top right corner to expand it, and check the "Primary PM" field for the name of your PM.
- Find their GitHub handle here.
Where can I find more information?
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
- Overview of Review Process for Community Contributions
- Pull Request Status Guide
- Making changes to your pull request
When can I expect my changes to be merged?
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
- The size and impact of the changes that it introduces
- The need for product review
- Maintenance status of the parent repository
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
@georgebabey any reason not to merge this?
Hi @georgebabey - bumping this!
@georgebabey, @mphilbrick211, just checking: if the change if fine, can we possibly merge this? Here is an example of a chained pull request where this fix would be helpful. You can see that tests aren't being run for it.
@georgebabey, @mphilbrick211, just checking: if the change if fine, can we possibly merge this? Here is an example of a chained pull request where this fix would be helpful. You can see that tests aren't being run for it.
Hi @0x29a - I'm looking into getting this reviewed for you.
Apologies for the delay, happy to get this merged, but it is out of date with base branch now
@e0d Sure, I pressed the update button. That's weird you couldn't, because I know GitHub has functionality to allow maintainers to update PRs even from private forks. I've used it myself as a maintainer on other projects. Maybe there's a setting we need to turn on for this repo?