edx-django-utils icon indicating copy to clipboard operation
edx-django-utils copied to clipboard

Replace isort quality check

Open jesperhodge opened this issue 8 months ago • 1 comments

Problem Description

Spending two hours to figure out why the CI quality pipeline fails due to how isort wants me to sort my inputs is a waste of time.

isort is not documented in the readme so there's no way to know that you can locally run the command to automatically sort the imports correctly.

The rules are also not clear.

This costs development time.

Solution

Ideally, just run isort in the pipeline automatically and autofix instead of checking, then include the change in the commit. Or just remove isort from the quality check. Import sorting is not worth the amount of time it costs to fix problems.

jesperhodge avatar Jun 13 '24 15:06 jesperhodge