edx-cookiecutters icon indicating copy to clipboard operation
edx-cookiecutters copied to clipboard

Issues uncovered while creating a new IDA

Open jmbowman opened this issue 1 year ago • 1 comments

A/C

  • [ ] Break the list below into reasonably-sized issues

I created https://github.com/edx/flashcards for a hackathon, and discovered several respects in which the IDA cookiecutter output was broken or just not ideal. Capturing here for now, although several of these should probably be broken out into separate issues and/or PRs for implementation.

  • Update the Dockerfile to include dev image and match recent best practices (it looks like there are a few existing PRs that may address this once merged, we should finish those)
  • Stop using deprecated MAINTAINER Dockerfile field (may be fixed in one of the existing PRs?)
  • Switch CHANGELOG.rst to use named Open edX releases rather than the essentially unused version number
  • Remove openedx.yaml (see https://github.com/openedx/open-edx-proposals/pull/526)
  • Add .vscode (for Visual Code Studio) to .gitignore
  • Do we still want .bowerrc? It seems unused.
  • Remove .github/workflows/pypi-publish.yml , since we don't publish IDA packages to PyPI
  • Remove renovate.json? I think we generally want to discourage having frontend code in IDAs, although it's conceivable that we might add a little for use in Django Admin..
  • Add missing "#" for make help entries to work (comments starting with "##" after the target name get used)
  • Add missing make target descriptions; at least some of these should probably be listed in make help
  • Fix pycodestyle & pylint failures out of the box
  • Add link to 2U-specific IDA creation instructions: https://2u-internal.atlassian.net/wiki/spaces/SRE/pages/19237450/Creating+A+New+Kubernetes+Django+Service

jmbowman avatar Oct 30 '23 15:10 jmbowman

There memcache tag being used is deprecated and docker-compose up won't work. Error message:

[DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of docker.io/library/memcached:1.4.24 to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/

I used the latest tag and it worked. Will that cause any issue?

zameel7 avatar Jul 04 '24 16:07 zameel7