edx-cookiecutters
edx-cookiecutters copied to clipboard
chore: optimize for best practices linter
Description:
This PR modifies the MAINTAINER flag deprecated by docker into the preferred LABEL system. It also moves the apt cache clear under under the apt command itself, in keeping with dockerfile optimization best practices.
Merge checklist:
- [ ] All reviewers approved
- [ ] CI build is green
- [ ] Changelog record added
- [ ] Documentation updated (not only docstrings)
- [ ] Commits are squashed
Thanks for the pull request, @thomty! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
- supporting documentation
- Open edX discussion forum threads
- timeline information ("this must be merged by XX date", and why that is)
- partner information ("this is a course on edx.org")
- any other information that can help Product understand the context for the PR
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
:warning: We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.
@thomty Thank you for your contribution!
Since there hasn't been any activity on this PR in a while I wanted to check in and see if it was still relevant?
You already got a positive review from @adzuci, so the next step towards getting this PR merged would be for you to sign the contributor agreement.
Hi @thomty! Just a quick update that we'll be closing this PR shortly because it is stale. You may reopen this pull request, or open a new one, when you have time to come back to this work.
CC @mphilbrick211
@thomty Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.