edx-cookiecutters icon indicating copy to clipboard operation
edx-cookiecutters copied to clipboard

Published 20 hours ago • verified publisher icon openedx

chore: Add Dockerfile linter

Open adzuci opened this issue 2 years ago • 0 comments

This PR is an attempt at testing out a fairly nascent linter and is being added due to a Slack converstion with SRE.

See https://github.com/openedx/edx-cookiecutters/pull/267 for competing linter

Currently we review dockerfiles by pasting them into https://www.fromlatest.io/#/ and reading https://2u-internal.atlassian.net/wiki/spaces/SRE/pages/19265642/Dockerfile+Best+Practices at 2U.

Docs: https://github.com/marketplace/actions/docker-lint (16 stars) Maintainer: https://github.com/luke142367 (4th year at Imperial College London)

Next steps:

  1. Address the three findings
  2. Consider adding an rc file based on https://github.com/replicatedhq/dockerfilelint#configuring

adzuci avatar Sep 28 '22 18:09 adzuci