django-config-models icon indicating copy to clipboard operation
django-config-models copied to clipboard

Estute/te 2873

Open estute opened this issue 5 years ago • 2 comments

Building on the work in Farhanah's hackathon project, I cleaned up the script to report on the state of waffle flags/switches/samples in a django app. I decided reduce the original scope of this script to exclude ConfigurationModels for the time being, as I encountered some bugs in pulling all of the data from the DB. This script only pulls waffle feature toggle data for now. Still, I think it makes sense to keep the management command in this repo for two reasons: 1) it is already installed in the platform and easy to include in others IDAs (rather than hosting it in a repo for general scripts) and 2) we will probably want to add the ability to report on ConfigurationModels in the future.

estute avatar Apr 04 '19 16:04 estute

Codecov Report

Merging #20 into master will decrease coverage by 1.88%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   93.71%   91.82%   -1.89%     
==========================================
  Files          12       13       +1     
  Lines         652      881     +229     
  Branches       43       68      +25     
==========================================
+ Hits          611      809     +198     
- Misses         34       65      +31     
  Partials        7        7
Impacted Files Coverage Δ
...agement/commands/generate_feature_toggle_report.py 0% <0%> (ø)
config_models/tests/test_config_models.py 99.08% <0%> (+0.11%) :arrow_up:
config_models/models.py 98.57% <0%> (+1.98%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c02e8d3...179bd45. Read the comment docs.

codecov-io avatar Apr 04 '19 18:04 codecov-io

@jmbowman right. I tested it at first w/ a hello-world django app I threw together, as well as w/ the platform via devstack. The trouble is that it would require not only the django app, but also some preloaded data/fixture. I like the idea of breaking out waffle_utils, because I think those could be useful in their own. I'll follow up w/ arch.

estute avatar Apr 04 '19 20:04 estute

Although this pull request is already closed, I'm still watching it for updates.

There is nothing you have to do. No action is needed from your side. Thanks.

openedx-webhooks avatar Nov 30 '22 21:11 openedx-webhooks