credentials icon indicating copy to clipboard operation
credentials copied to clipboard

build: adding python3.11 support.

Open awais786 opened this issue 1 year ago • 1 comments

Supporting python3.11.

awais786 avatar Feb 19 '24 18:02 awais786

@awais786 what's the status of this, are you still working on it?

feanil avatar Apr 08 '24 14:04 feanil

So failures are coming due to 3.11.9, on [3.11.7, 3.11.8] these tests are working fine. I am trying to findout the root cause. https://github.com/python/cpython/commit/f97f25ef5dfcdfec0d9a359fd970abd139cf3428

I found the root cause. https://github.com/django/django/pull/17979#issuecomment-2061194558

awais786 avatar Apr 17 '24 07:04 awais786

@feanil this seems valid issue. https://github.com/django/django/pull/17979#issuecomment-2061194558

awais786 avatar Apr 18 '24 10:04 awais786

Only coverage is failing due to some token issue.

awais786 avatar Apr 25 '24 12:04 awais786

Only coverage is failing due to some token issue.

we know about the coverage failures, so not worried about that. Is this ready for review and (if it passes review) merge, in your opinion, @awais786? Or should we wait for 3.11.9 fix?

deborahgu avatar Apr 30 '24 16:04 deborahgu

Only coverage is failing due to some token issue.

we know about the coverage failures, so not worried about that. Is this ready for review and (if it passes review) merge, in your opinion, @awais786? Or should we wait for 3.11.9 fix?

@deborahgu you can review this PR and merge if its look fine. We can update python version after 6th may once django version release.

awais786 avatar May 02 '24 16:05 awais786

@awais786 the Django update is out, can you re-base and re-build requirements?

feanil avatar May 06 '24 14:05 feanil

@awais786 the Django update is out, can you re-base and re-build requirements?

I tried yesterday but i have lost push rights. @iamsobanjaved is working on this now.

awais786 avatar May 07 '24 09:05 awais786

I think I have permission to rebase and rebuild requirements, which I will do in a few minutes, since it's on me that I pulled in new requirements before grabbing this branch.

deborahgu avatar May 07 '24 15:05 deborahgu