credentials icon indicating copy to clipboard operation
credentials copied to clipboard

Published 20 hours ago • verified publisher icon openedx

build: Adding django linter for migrations.

Open awais786 opened this issue 2 years ago • 3 comments

Description

  • POC PR to add django-migration-linter to test/inspect the migrations created in the PRs and identify the backwards incompatible migrations before they are merged to master.

awais786 avatar Aug 26 '22 10:08 awais786

Exciting work! Let me know when it's ready for review.

hurtstotouchfire avatar Sep 09 '22 21:09 hurtstotouchfire

Hi @awais786 and @UsamaSadiq - Just checking in- is this ready for review?

mphilbrick211 avatar Oct 26 '22 01:10 mphilbrick211

Hi @mphilbrick211 This PR has been created as a proof of concept for the migration-linter tool. we are waiting for the final decision on the approach by the ArchBOM team. Once the approach is finalised, we'll update the status of the PR and will merge it.

UsamaSadiq avatar Oct 26 '22 01:10 UsamaSadiq

Hi @awais786 and @UsamaSadiq -- this PR hasn't been updated in awhile and is still a draft.

I am planning on closing this tomorrow. Please let me know if you're planning on picking this up again soon and we need to continue to keep it open.

justinhynes avatar Nov 30 '22 20:11 justinhynes

Hi @justinhynes This PR has been created an an example PR for a POC of a new tool django-migration-linter. I'd like to request keeping these PRs open for a while so we can do the final discussion and decide the further approach on it.

UsamaSadiq avatar Dec 02 '22 07:12 UsamaSadiq

@UsamaSadiq Is there a ticket for this that we can watch? I would like to see us try something on this front.

hurtstotouchfire avatar Dec 02 '22 22:12 hurtstotouchfire

Hi @hurtstotouchfire We don't have any public issue created for this POC yet. A 2u-internal documents for the POC findings have been created for review right now. I'll update the status on the PR as soon as we get a green signal or any comments on this approach.

UsamaSadiq avatar Dec 06 '22 12:12 UsamaSadiq

Hey @awais786 & @UsamaSadiq,

What is the status on this POC? Do we need to keep this PR open? It's been open for almost a year now and hasn't had any movement in 6 months.

Thanks!

justinhynes avatar Jun 22 '23 13:06 justinhynes

In an effort to cleanup inactive PRs, I will be closing this PR. Please feel free to re-open if needed. I won't delete the branch either.

justinhynes avatar Jul 25 '23 18:07 justinhynes