openedx
fix: replace headless property in browser options class
PR Summary
This small PR resolves the Selenium deprecation warnings coming from the headless property which you can find in the CI logs:
DeprecationWarning: headless property is deprecated, instead use add_argument('-headless')
Thanks for the pull request, @emmanuel-ferdman!
This repository is currently maintained by @openedx/2u-phoenix.
Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
:radio_button: Get product approval
If you haven't already, check this list to see if your contribution needs to go through the product review process.
- If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
- If it doesn't, simply proceed with the next step.
:radio_button: Provide context
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
- Dependencies
This PR must be merged before / after / at the same time as ...
- Blockers
This PR is waiting for OEP-1234 to be accepted.
- Timeline information
This PR must be merged by XX date because ...
- Partner information
This is for a course on edx.org.
- Supporting documentation
- Relevant Open edX discussion forum threads
:radio_button: Get a green build
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
Where can I find more information?
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
- The size and impact of the changes that it introduces
- The need for product review
- Maintenance status of the parent repository
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
Hi @emmanuel-ferdman - thank you for this contribution! Please let me know if you have any questions regarding submitting a CLA form. Thanks!
@emmanuel-ferdman Your branch is behind the base. I've pulled in changes from master as a merge commit which will update your branch and cause the tests to be re-run.
@emmanuel-ferdman sorry for the delay, but was away for the Open edX conference. It looks like there are some quality errors. Can you have a look. I'm not sure what's causing the migration checks to fail, but will look when I have a moment.
@emmanuel-ferdman there seem to be some failing checks that will need to be resolved.
@e0d @mphilbrick211 anything else is needed from my side?
@emmanuel-ferdman - no, we will try to get this looked at for you asap!
Hi @emmanuel-ferdman -- there are some extra checks that need to be run. Would you mind taking a look?
I think just rebasing and pushing again will get the tests unstuck.
@emmanuel-ferdman hi there! Just checking in - are you still planning to pursue this pull request?
@mphilbrick211 I was actually waiting on your side - CI looks unstable. Tests pass locally, and from the CI logs the failures don’t appear related to this PR (some random installation issue).
@mphilbrick211 I was actually waiting on your side - CI looks unstable. Tests pass locally, and from the CI logs the failures don’t appear related to this PR (some random installation issue).
@bmtcril are you able to help with this?
I think @openedx/2u-catalog is in charge of this repo now? Phoenix is listed in catalog-info, but I think that team is gone. The problems seem to stem from the Dockerfile being based on a very old version of Ubuntu that's starting to lose support.
Hi @bmtcril , Thanks for pointing that out! We’re already working on this issue, and a PR has been raised to fix it. https://github.com/openedx/course-discovery/pull/4686
Hi @mphilbrick211, I see the CI checks are stable now. Since I don’t have write access to approve and merge this PR, @UsamaSadiq could you please help review and merge it?