course-discovery icon indicating copy to clipboard operation
course-discovery copied to clipboard

Published 20 hours ago • verified publisher icon openedx

feat: add python311 support

Open ichintanjoshi opened this issue 10 months ago • 2 comments

Description

This PR contains changes for upgrading python 3.8 to python 3.11.

Changes include :-

  • Dependencies and version upgrades

Done as a part of following :-

  • https://github.com/openedx/public-engineering/issues/233
  • https://github.com/openedx/edx-platform/issues/34229
  • https://github.com/openedx/course-discovery/issues/4307

ichintanjoshi avatar Apr 08 '24 13:04 ichintanjoshi

Thanks for the pull request, @ichintanjoshi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks avatar Apr 08 '24 13:04 openedx-webhooks

Hi @openedx/course-discovery-maintainers! Would someone be able to review this for us? Thanks!

mphilbrick211 avatar Apr 10 '24 16:04 mphilbrick211

@ichintanjoshi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Apr 15 '24 06:04 openedx-webhooks

This PR didn't run unit tests on python 3.11 and 3.12 versions because these versions weren't available on the docker image and the test suites just skipped unit tests. For the services that run CI on docker, we need to modify Dockerfile as well.

py311-django42: skipped because could not find python interpreter with spec(s): py311

https://github.com/openedx/course-discovery/actions/runs/8684080396/job/23811059094#step:4:1646

py312-django42: skipped because could not find python interpreter with spec(s): py312

https://github.com/openedx/course-discovery/actions/runs/8684080396/job/23811059586#step:4:1646

iamsobanjaved avatar Apr 15 '24 12:04 iamsobanjaved

@iamsobanjaved or @ichintanjoshi is one of you working on fixing this?

feanil avatar May 03 '24 16:05 feanil

Yup @feanil, almost ready, just need to clean commits, will do shortly.

Fix: https://github.com/openedx/course-discovery/pull/4328

iamsobanjaved avatar May 03 '24 16:05 iamsobanjaved

@feanil I am coming back from vacation on Monday and will take a look into it.

ichintanjoshi avatar May 03 '24 16:05 ichintanjoshi

#4328 is ready for review, it updates the Dockerfile to add support for Python 3.11 and 3.12

cc @feanil @ichintanjoshi

iamsobanjaved avatar May 07 '24 13:05 iamsobanjaved