codejail icon indicating copy to clipboard operation
codejail copied to clipboard
verified publisher icon openedx

Test codejail on Python 3.11

Open feanil opened this issue 1 year ago • 2 comments

This repository is a depedency of edx-platform and needs to be upgraded to Python 3.11 before the Readwood release is cut (mid-April).

  • [ ] Requirements are compiled with Python 3.8
  • [ ] Tests are run on Python 3.8 and 3.11
  • [ ] (Optional) Tests are also run with 3.12 and passing or 3.12 issues are ticketed.
  • [ ] Classifiers in setup.py setup.cfg or pyproject.toml indicate Python 3.11 support
  • [ ] A new version is release to PyPI
  • [ ] A PR is merged to edx-platform to use the new version

feanil avatar Mar 25 '24 13:03 feanil

This ticket will handle upgrading codejail itself to 3.11. As a follow-up, we will need to upgrade edx-platform's codejail execution environment (a.k.a. edx-sandbox) to Python 3.11/3.12: https://github.com/openedx/edx-platform/issues/34469

kdmccormick avatar Apr 03 '24 19:04 kdmccormick

assign me

ichintanjoshi avatar Apr 05 '24 15:04 ichintanjoshi

I just took a look at the CI for this repo and it looks like it's quite complicated. I think in order to test on newer versions, we'll first have to add a new Dockerfile that is the same as the existing one but tests in python 3.11.

Then we'll have to update push-docker-image workflow to publish 2 images, one at latest and one at the 3.11 tag. Once that has landed, we should be able to run tests on the latest or the 3.8 image.

feanil avatar Apr 16 '24 14:04 feanil

Hi @feanil, I would like to help on the 3.11 upgrade. If you are lacking on bandwidth I can take on this issue. Or if you need help somewhere else I can give a hand.

MoisesGSalas avatar Apr 19 '24 14:04 MoisesGSalas

@MoisesGSalas I think this one is a bit complicated and I'm already working on it, but maybe you could take a look at https://github.com/openedx/credentials/pull/2389 and suggest/make a further PR to get tests passing on Credentials.

feanil avatar Apr 23 '24 13:04 feanil

I was focusing on this one because I was recently appointed as maintainer for the codejail repo, so I would really like to one something related to it to get more familiar (even if it's not this specific task).

I do have a bit of experience running codejail (mostly k8s) so I would like to hear any recommendation on where I can help. (I can still check the credentials one, but literally have 0 experience with that service).

MoisesGSalas avatar Apr 23 '24 14:04 MoisesGSalas

Ah, gotcha, @MoisesGSalas take a look at https://github.com/openedx/codejail/pull/167 please review.

feanil avatar Apr 24 '24 16:04 feanil