edx-app-ios
edx-app-ios copied to clipboard
iOS - Update web view cookie with in-app selected language
Description
Create and set web view cookie with the selected language locale. Cookie name should be "prod-edx-language-preference" and its value should be selected language locale.
How to test this PR
- [ ] Web view language should be updated as device selected language.
Codecov Report
:exclamation: No coverage uploaded for pull request base (
master@d680f2f
). Click here to learn what that means. The diff coverage is0%
.
@@ Coverage Diff @@
## master #1333 +/- ##
========================================
Coverage ? 52%
========================================
Files ? 432
Lines ? 27317
Branches ? 0
========================================
Hits ? 14473
Misses ? 12844
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
Source/WKWebView+LanguageCookie.swift | 0% <0%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d680f2f...afcf622. Read the comment docs.
@mumer92 Please rebase the code with latest master update.
@mumer92 When i am changing the language to Spanish the discovery webvew is not updating the language. Can you please check whats the reason for it?
@salman2013
Cookie is being applied to webview, but seems like it is not loading specific language.

Seems like it is being applied on device.