edx-app-ios icon indicating copy to clipboard operation
edx-app-ios copied to clipboard

iOS - Update web view cookie with in-app selected language

Open mumer92 opened this issue 5 years ago • 5 comments

Description

LEARNER-7498

Create and set web view cookie with the selected language locale. Cookie name should be "prod-edx-language-preference" and its value should be selected language locale.

How to test this PR

  • [ ] Web view language should be updated as device selected language.

mumer92 avatar Jan 28 '20 11:01 mumer92

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d680f2f). Click here to learn what that means. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1333   +/-   ##
========================================
  Coverage          ?     52%           
========================================
  Files             ?     432           
  Lines             ?   27317           
  Branches          ?       0           
========================================
  Hits              ?   14473           
  Misses            ?   12844           
  Partials          ?       0
Impacted Files Coverage Δ
Source/WKWebView+LanguageCookie.swift 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d680f2f...afcf622. Read the comment docs.

codecov[bot] avatar Jan 28 '20 11:01 codecov[bot]

@mumer92 Please rebase the code with latest master update.

salman2013 avatar Feb 04 '20 13:02 salman2013

@mumer92 When i am changing the language to Spanish the discovery webvew is not updating the language. Can you please check whats the reason for it?

IMG_0220

salman2013 avatar Feb 06 '20 07:02 salman2013

@salman2013

Cookie is being applied to webview, but seems like it is not loading specific language.

Screenshot 2020-02-06 at 12 54 11 PM

mumer92 avatar Feb 06 '20 07:02 mumer92

Seems like it is being applied on device.

IMG_8969

mumer92 avatar Feb 06 '20 10:02 mumer92