configuration icon indicating copy to clipboard operation
configuration copied to clipboard

Update main.yml

Open alextoro85 opened this issue 2 years ago • 3 comments

command: "npm install -g npm@{{ INSIGHTS_NPM_VERSION }}" is giving syntax error.

Maybe this can be used with shell too

Configuration Pull Request

Make sure that the following steps are done before merging:

  • [ ] A SRE team member has approved the PR if it is code shared across multiple services and you don't own all of the services.
  • [ ] Are you adding any new default values that need to be overridden when this change goes live? If so:
    • [ ] Update the appropriate internal repo (be sure to update for all our environments)
    • [ ] If you are updating a secure value rather than an internal one, file a SRE ticket with details.
    • [ ] Add an entry to the CHANGELOG.
  • [ ] If you are making a complicated change, have you performed the proper testing specified on the Ops Ansible Testing Checklist? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).
  • [ ] Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?

alextoro85 avatar Sep 16 '22 12:09 alextoro85

Thanks for the pull request, @alextoro85! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

:warning: We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

openedx-webhooks avatar Sep 16 '22 12:09 openedx-webhooks

@alextoro85 Thank you for the contribution. Once the agreement has been sorted out, we will be able to review your code.

natabene avatar Sep 19 '22 15:09 natabene

@alextoro85 Have you had a chance to submit the CLA form?

natabene avatar Oct 13 '22 19:10 natabene

Hi @alextoro85! Just checking back in on this. Are you planning to pursue this PR? If so, you will need to complete a CLA form as stated above. Thank you!

mphilbrick211 avatar Dec 28 '22 20:12 mphilbrick211

@alextoro85 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Jan 11 '23 01:01 openedx-webhooks

Closing due to inactivity.

mphilbrick211 avatar Jan 11 '23 01:01 mphilbrick211