configuration icon indicating copy to clipboard operation
configuration copied to clipboard

Error when executing make docker.pkg

Open dalareo opened this issue 9 years ago • 4 comments

#Steps to replicate:

  • executing make docker.pkg

Syntax error at docker.mk file:

.build/%/Dockerfile.pkg: docker/build/%/Dockerfile Makefile
	@mkdir -p .build/$*
@sed -E "s#FROM edxops/([^:]+)(:\S*)?#FROM \1:test#" $< > $@

the last line should be:

@sed -E "s#FROM edxops/([^:]+)(:\S*)?#FROM \1:latest#" $< > $@

dalareo avatar Dec 12 '16 15:12 dalareo

@clintonb What do you think of this? It does look like Dockerfile.test and Dockerfile.pkg have identical actions in docker.mk

nedbat avatar Dec 15 '16 11:12 nedbat

But no edxops/precise-common:test image is available!!, e.g

dalareo avatar Dec 15 '16 11:12 dalareo

I must defer to @cpennington since he wrote the file originally. I only modified it to get things building on OS X (https://github.com/edx/configuration/pull/2868/commits/7cd04db1d90b57c67a098c83ae322697492415e0), but I (clearly) did not attempt to use all of the Make targets.

@dalareo what goal can we help you achieve? Do you need these targets to work? If we decide to get rid of them (since it seems no one has used them) would you mind?

@cpennington what was your original intent with these targets?

clintonb avatar Dec 15 '16 13:12 clintonb

I am trying to deploy Edx with Docker and I need to build and package images first, ad lobg as there is no available versions for all the services at Docker Hub

dalareo avatar Dec 15 '16 14:12 dalareo