configuration icon indicating copy to clipboard operation
configuration copied to clipboard

edxapp role won't put ELASTIC_SEARCH_CONFIG into cms_env_config

Open bryanlandia opened this issue 8 years ago • 0 comments

This is important because if you host elasticsearch somewhere other than localhost, your CMS will not be able to access it to do indexing. I can get together a PR but need to update my local to Eucalyptus/master and branch from that first.

edx-platform has been fixed in commit https://github.com/edx/edx-platform/commit/5fe1a114eab55453525c8127854271637755c6fb to get a value for EDXAPP_ELASTIC_SEARCH_CONFIG from env_tokens.

My configuration repo is at https://github.com/edx/configuration@af01848b91a0b228a33da667f284c3dfacd66aba

Steps to replicate:

  • run /edx/bin/update edx-platform
  • check cms.env.json
  • cms.env.json won't have a key for EDXAPP_ELASTIC_SEARCH_CONFIG
diff --git playbooks/roles/edxapp/defaults/main.yml playbooks/roles/edxapp/defaults/main.yml
index 8f6564e..5b29e46 100644
--- playbooks/roles/edxapp/defaults/main.yml
+++ playbooks/roles/edxapp/defaults/main.yml
@@ -1038,6 +1038,7 @@ cms_auth_config:
   PARSE_KEYS: "{{ EDXAPP_PARSE_KEYS }}"
 cms_env_config:
   <<: *edxapp_generic_env
+  ELASTIC_SEARCH_CONFIG: "{{ EDXAPP_ELASTIC_SEARCH_CONFIG }}"
   SITE_NAME:  "{{ EDXAPP_CMS_SITE_NAME }}"
   GIT_REPO_EXPORT_DIR: "{{ EDXAPP_GIT_REPO_EXPORT_DIR }}"

edxapp_main_yml.patch.txt

bryanlandia avatar Aug 12 '16 19:08 bryanlandia