zfs-localpv icon indicating copy to clipboard operation
zfs-localpv copied to clipboard

Draft: chore(build): replace k8s.io/utils/mount with k8s.io/mount-utils

Open hensur opened this issue 6 months ago • 5 comments

Currently waiting for https://github.com/openebs/lib-csi/pull/21 to be merged. I'm replacing the upstream dependency with my fork, after lib-csi has been updated, I will remove that replace.

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?: On Nodes with high mount activity, older versions of k8s mount-utils (or utils/mount) would call ConsistentRead to workaround a kernel bug which would skip mount entries on mount activity during a read. See https://github.com/kubernetes/mount-utils/commit/4ae857e44d3bd822b24424772a3bcee395a0fcf2

We noticed that the zfs provisioner would return an InconsistentRead error when the node was attaching a lot of volumes (mostly after reboots).

What this PR does?:

replaces the k8s.io/utils/mount dependency with k8s.io/mount-utils

the upstream package has been renamed: https://github.com/kubernetes/utils/tree/master/mount

The new version also includes the aforementioned fix.

Does this PR require any upgrade changes?: No

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? : I'm not exactly sure why go mod tidy deems it necessary to also bump the module version (as well as some package versions). I assume some library requires an up to date go version, which is why this module now has to require that version as well.

Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • [ ] Fixes #
  • [x] PR Title follows the convention of <type>(<scope>): <subject>
  • [ ] Has the change log section been updated?
  • [ ] Commit has unit tests
  • [ ] Commit has integration tests
  • [ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • [ ] (Optional) If documentation changes are required, which issue on https://github.com/openebs/website is used to track them:

hensur avatar Aug 01 '24 08:08 hensur